•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TD-FIRMWARE-LDT-1394-1 13 Mar 2026

done updated below in the function as well.

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

BN APPROVES.

LEAHI-APPLICATION-LDT-3574-1 12 Mar 2026

delete

LEAHI-APPLICATION-LDT-3574-1 12 Mar 2026

remove one set of braces

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

The timeout should be 5 minutes (300 secs) when in pause state, 0 when in ramp or run state. Use a #define for the 300 (5 * SEC_PER_MIN).

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Updated

LEAHI-APPLICATION-LDT-3698-1 16 Mar 2026

Let's discuss the changes made in this file.
Since this is the base class, I am a little concerned about the Reinseback-specific logics added here.
shouldn't be in the EndRinseback.... qml.

This also being used for the recirculate.

LEAHI-APPLICATION-LDT-3678-1 17 Mar 2026

removed

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

I was thinking that comment should go above the first if statement.

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

else TD ?

UI-DENBUG-331-1 17 Feb 2026

RESOLVED
BN Approves

LEAHI-DD-FIRMWARE-LDT-3628-1 18 Mar 2026

Add TODO comment to restore later.

LEAHI-APPLICATION-LDT-3433-1 10 Mar 2026

add checks to doPopulateAcidConcentrate() method

LEAHI-TESTSUITES-LDT-2085-1 30 Sep 2025

Same as what Tiffany Mejia mentioned.
However, these types of object definitions are worth it since the text '75' is the result of the sent message, and this value will change with each different message payload.

LEAHI-APPLICATION-LDT-3433-1 11 Mar 2026

fixed

LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cases. Consider changing variable name to something like dialysateToDialyzerFlowRate and updating function description in header to make this more clear.

LEAHI-DD-FIRMWARE-LDT-3603-1 12 Mar 2026

Updated

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

FALSE?

LEAHI-APPLICATION-LDT-1440-1 29 Sep 2025

StoppedSlider.qml

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

changed accordingly.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

removed from everywhere

LEAHI-TD-FIRMWARE-LDT-1840-1 13 Mar 2026

Still not packed.

LEAHI-DIALIN-LDT-3629-1 12 Mar 2026

tip: use the logger and set the statement to error level and you can see it in runtime

LEAHI-DIALIN-LDT-3629-1 12 Mar 2026

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Verified image is square. Image is being used in multiple places, so leaving image as is.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Remove file from branch.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Add comments for all if Def, Min, Max, or Res is intentionally missing. Reference DataList.conf.

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Expand alt/rejected to cover entire message path.

LEAHI-DD-FIRMWARE-LDT-3352-1 12 Mar 2026

Done.

TD-LDT-1886-7 29 Sep 2025

posA = posC + ( ( curPos - posC ) / 2 );

TD-LDT-1886-7 29 Sep 2025

Why are you removing this check?

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN RESOLVED

LEAHI-DIALIN-LDT-696-1 20 Mar 2026

RECOVERY_STATES

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

this state i believe is now obsolete or combined in the main blood return page as before it went to a separate saline page but now it goes back to this page according to caryn

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

updated.

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

BN APPROVES.

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

BN APPROVES.

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

Assign bloodPrimeStartMS here to mark start of pause.

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

elapsedSec will count up. The countdown should be time remaining ( timeout - elapsedSec ) when in pause state, zero when in ramp or run state.

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

I'm not seeing where alarms get triggered?

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Sorry, Updated

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

What is this?

LEAHI-TD-FIRMWARE-LDT-3215-1 19 Mar 2026

Added

UI-DENBUG-331-1 20 Mar 2026

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3103-3 24 Mar 2026

updated

LEAHI-DIALIN-LDT-696-1 26 Mar 2026

Added