•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add space between } and type name.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Seems like eePromDataTX is an output, not an input.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

If both monitor and driver need visibility to something, consider moving it to the driver's header file since monitor needs to include driver anyway. Driver should not have to know about the monitor stuff as it is higher level.

LEAHI-TESTSUITES-LDT-2174-1 26 Nov 2025

These steps should outline the sections in the report https://diality.atlassian.net/browse/LDT-2176. Please sync them up so they match the flow

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Should we be calling get function in monitor instead of driver here?

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 24 Nov 2025

Resolved Thanks

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs to include RR broadcast related variables.

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

I do not see structure packing. is it not required ?

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Remove extra blank line.

LEAHI-TESTSUITES-LDT-2174-1 27 Nov 2025

Added the sections in the report

LEAHI-TESTSUITES-LDT-2174-1 27 Nov 2025

Added test.endsection in the report

LEAHI-TESTSUITES-LDT-2174-1 27 Nov 2025

Removed the Visible property in the objects

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Fixed

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Updated, missed to increment.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Updated. Now using 0x71

LEAHI-RO-FIRMWARE-LDT-2116-1 01 Dec 2025

Structure packing statement missing. add it even if not required

LEAHI-TD-FIRMWARE-LDT-1886-1 01 Dec 2025

Done

LEAHI-TD-FIRMWARE-LDT-1886-1 01 Dec 2025

Should we initialize to inactive (and use #define)?

LEAHI-RO-FIRMWARE-LDT-2116-1 01 Dec 2025

Once Dara enable the copyright script, that will handle it

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

not initialized in init function

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

Not initialized ? who modifies this variable ?

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Input is roRejectionRatio.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roRRAvg is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Input is roRejectionRatioTankFill.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Declare local variables at top of scope (top of function in this case).

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

isFlushComplete looks like an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roRRTankFillAvg is an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

concentateFlushTankFullTimer looks like an input.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

isFlushComplete in an output. pendingStartConcentrateFlushRequest appears to be an input and an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs (throughout this unit).

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

These divisions should have a divide by zero check.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roPumpState is not an array. stopPumpRequest isn't referenced in this function. targetROPumpFlowRate is an input and an output and there are others.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2004-1 01 Dec 2025

For default cases (throughout this unit), we either need a s/w fault (because this should never happen and indicates memory corruption) or a comment noting it is ok to ignore invalid cases (commands in this case).

LEAHI-DD-FIRMWARE-LDT-2004-1 01 Dec 2025

All cases seem a little off on indents, especially this one.

LEAHI-DD-FIRMWARE-LDT-2004-1 01 Dec 2025

Why two output lines?

LEAHI-TESTSUITES-LDT-1802-1 02 Dec 2025

updated. Removed header bar information and device settings information objects

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Add space before );

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs throughout this unit.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

isFlushComplete looks like an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Should be 2 blank lines before/after test banner.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roRejectionRatioTankFill is also an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Add blank line between declaration and rest of code in scope.