•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3103-3 24 Mar 2026

done

LEAHI-DD-FIRMWARE-LDT-2004-9 30 Mar 2026

Remove extra blank lines.

LEAHI-TESTSUITES-LDT-3188-1 30 Mar 2026

just add and not replace test case list

LEAHI-TESTSUITES-LDT-2278-1 30 Mar 2026

when is goes through here. the page is stuck on the feature configuration page... Please do the check before going into pre treatment so the flow does not get messed up.

LEAHI-TESTSUITES-LDT-2839-1 30 Mar 2026

instead of hard coding can you test against the INSTITUTIONAL_CONFIGURATIONS_BLOOD_FLOW_CUSTOM_RANGE[vBloodFlowDef] ? update for each of these

LEAHI-DD-FIRMWARE-LDT-3103-3 24 Mar 2026

the else part here, should handle greater than Qd: 300?

LEAHI-TESTSUITES-LDT-2839-1 31 Mar 2026

updated as per comment

LEAHI-TESTSUITES-LDT-3188-1 31 Mar 2026

removed all post treatment steps

LEAHI-DD-FIRMWARE-LDT-1477-1 02 Apr 2026

Reverse order of comparison.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Fix comment alignment.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Remove this.

LEAHI-TD-FIRMWARE-LDT-473-3 06 Apr 2026

Is it an enum/index like Denali then?

LEAHI-DD-FIRMWARE-LDT-3749-2 07 Apr 2026

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

LEAHI-DD-FIRMWARE-LDT-1195-2 06 Apr 2026

Can this statement be 'else if' case after BC switch only request handling (after line 1013). Just in case both requests (switch only and regular one) came together and only 'switch only' handled first.

LEAHI-DD-FIRMWARE-LDT-3103-3 01 Apr 2026

More implied boolean assignments.

LEAHI-DD-FIRMWARE-LDT-3352-1 03 Apr 2026

Done

LEAHI-DD-FIRMWARE-LDT-1477-1 02 Apr 2026

Reverse order of comparison

LEAHI-DD-FIRMWARE-LDT-1477-1 02 Apr 2026

Reverse order of comparison.

LEAHI-DD-FIRMWARE-LDT-1195-2 11 Mar 2026

Should we set the other switch to FALSE, just in case?

LEAHI-DD-FIRMWARE-LDT-3103-3 06 Apr 2026

removed.

LEAHI-TD-FIRMWARE-LDT-473-3 08 Apr 2026

From what I see in UI, it is just a range value not an enum/index

LEAHI-DD-FIRMWARE-LDT-3103-3 06 Apr 2026

Remove blank line. Also, add comments on the key logics for reference.

LEAHI-DD-FIRMWARE-LDT-2008-1 08 Apr 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2008-1 08 Apr 2026

Add blank line before return.

LEAHI-DD-FIRMWARE-LDT-3749-2 08 Apr 2026

FALSE?

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-SW-PLUGINS-SIM-LDT-2264-1 10 Oct 2025

no i removed this and other imports not needed

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-DIALIN-LDT-1440-1 11 Oct 2025

RESOLVED.

LEAHI-DIALIN-LDT-1440-1 11 Oct 2025

RESOLVED.

LEAHI-DIALIN-LDT-1440-1 10 Oct 2025

should be unsigned.

TD-LDT-1886-7 29 Sep 2025

Add blank line before return.

LEAHI-APPLICATION-LDT-3393-1 12 Mar 2026

BN approved

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

I am currently using all of them.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-DD-FIRMWARE-LDT-1195-2 11 Mar 2026

isBalChamberSwitchingOffRequested is an output.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Align indent

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Can we remove these 2 lines of code?

LEAHI-TD-FIRMWARE-LDT-1394-1 13 Mar 2026

Intentional?

LEAHI-TESTSUITES-LDT-3188-1 31 Mar 2026

No, it will not affect others test cases. Initially this was def setObjectText(obj, text): but divya changed to setObjectText(text, obj): So I changed back original because It was affecting my test scripts and I informed her about this

LEAHI-APPLICATION-LDT-3413-1 10 Mar 2026

remove hoverenabled

LEAHI-DD-FIRMWARE-LDT-3603-2 31 Mar 2026

Updated, thanks

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Is it time to restore now?

LEAHI-APPLICATION-LDT-3698-1 16 Mar 2026

If the "additional" word is used for the recirculate, please update everywhere to recirculate.
The additional is for extra blood return,
and recirculation is just to recirculate the blood to prevent clogging.

Please update in other files as well.

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

BN APPRVOES

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

Should probably initialize your new stall counter variable.

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

Define what 3 means (#define up top). If 3 means 3 x 50ms general task interval, define it as shown below:
#define AIR_PUMP_STALL_PERSISTENCE ( 150 / TASK_GENERAL_INTERVAL ) ///< How long stall condition must persist before alarming.

OR use persistent alarm.

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

Add a comment explaining what we're looking for here (i.e. we are commanding air pump to run but zero measured pump speed indicates it is not running).