•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it.

LEAHI-DD-FIRMWARE-LDT-1773-1 12 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-2707-1 16 Dec 2025

can we merge these slots with the ones in TreatmentAdjustmentVitals?

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Deleted.

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

Please move this to level sensor enum. this is not a conductivity sensor; it is a conductive Level sensor.

LEAHI-TD-FIRMWARE-LDT-1886-1 16 Dec 2025

The else in this trinary looks wrong - doesn't round up to multiple of 8.

LEAHI-DD-FIRMWARE-LDT-2185-1 17 Dec 2025

Plan is for 4 wire and currently there is no data for both 2 wire and 4 wire . So its TODO list and hence mark it as resolved

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

call vInstitutionalRecord.doAdjustment() and update advanced to do the same

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

U32

LEAHI-TD-FIRMWARE-LDT-1886-1 18 Dec 2025

We tend to initialize the local variables as a standard practice.

LEAHI-DD-FIRMWARE-LDT-2185-1 18 Dec 2025

Can we remove this code?

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

handleRxState should stay private. I removed the prototype from the header and kept a static prototype in ModePreTreat.c only, so the function remains internal to this unit.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Typically, we just match the unit file name here - so would be __TX_PARAMS_H__

LEAHI-TD-FIRMWARE-LDT-1886-1 02 Dec 2025

Done

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

As everything is of size 32 bits, skipped it

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

I think we need 2 public get functions that takes a dialyzer type (enum) parameter and return a blood volume or dialysate volume from this look-up table.

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

There are a few available messages at the top. Like MSG_ID_AVAILABLE_1. Could you please use one them?

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Updated

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Resolved. Thanks

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Resolved.

LEAHI-TESTSUITES-LDT-1630-1 03 Dec 2025

remove visible property

LEAHI-TESTSUITES-LDT-1630-1 03 Dec 2025

move to a common functions file

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

Report has been updated in the jira

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

This should say Validate. Can we change message here and add a test to test the button text. Before validation should test it says validate and then after fw validates the button should say confirm and test text and then mouse click it

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Fixed. thanks

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Updated

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

Renamed the function as per your suggestion

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

moved this function into utility.py file and changed the name as get_title_text_parameter

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

As per create treatment test script comment removed this function

LEAHI-TESTSUITES-LDT-1802-1 10 Dec 2025

updated as per comment

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Add blank line before return.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Accidental change here?
We should be deleting the ModeTxParams.c and .h files anyway.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Missing param line in function header.

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

updated

LEAHI-TESTSUITES-LDT-2174-1 02 Dec 2025

remove all snoozes

LEAHI-TESTSUITES-LDT-1630-1 05 Dec 2025

Please add the test case to the suite.conf

LEAHI-TD-FIRMWARE-LDT-473-1 09 Dec 2025

I don't think we need this signal function since this is not a mode anymore. Is this function being called somewhere?

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Put space between if and ( for all conditions in this function.

LEAHI-TESTSUITES-LDT-2174-1 07 Dec 2025

Rename the method name to set_Object_Text

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Done

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Please add function header.

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Suggestive comment => Shall we do it as a run time configurable so that we don't need to change the code?

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

do we need override function for high flow rate , low flow rate, conductivity, pressure etc ?

LEAHI-TESTSUITES-LDT-1454-1 09 Dec 2025

Moved this file into utilty.py file

LEAHI-DD-FIRMWARE-LDT-2004-3 09 Dec 2025

Shouldn't EVERY state set ALL valves?