•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

align indentations

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

align indentations

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Please remove all the imports not being used

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

you can remove the top portion as its not correct. This will get generated later

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

remove commented out line

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

venous_RangeBar

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

dial_tmp_value

LEAHI-TESTSUITES-LDT-1218-1 14 Oct 2025

when adding new items please organize and align as done initially

LEAHI-TESTSUITES-LDT-1057-1 14 Oct 2025

if this is added by us please add and push in the test suite. My test suite can not run

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Removed the pressure_text_obj method.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Removed visible parameter and aligned all objects.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

align indentations

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Please remove all the waits. It is not needed and just makes the test run longer. The quish.waitForObject should be your wait by giving it a timeout. If the object can not be found then add a longer timeout.

e.g.
arterial_rangeBar = utility.get_object_from_names(names.arterial_RangeBar, error_message="arterial rangeBar object is missing", timeout_ms=1000)

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Remove the following as I do not see these being used anywhere

mainTreatmentScreen_arterialRangeBar_RangeBar
mainTreatmentScreen_arterialRangeBar_RangeBar_marker
mainTreatmentScreen_venousRangeBar_RangeBar
mainTreatmentScreen_venousRangeBar_RangeBar_marker
mainTreatmentScreen_tempRangeBar_RangeBar
mainTreatmentScreen_tempRangeBar_RangeBar_marker

LEAHI-DIALIN-LDT-2428-1 16 Oct 2025

how come we need to add the path here?

TD-LDT-1886-7 16 Oct 2025

Replace measured current with measured torque.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Removed all waits.

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

Remove visible parameter and please align spacing between each how it was before along with the new objects

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

LEAHI-DD-FIRMWARE-LDT-3352-1 12 Mar 2026

Done.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

if ( TRUE == testChangeSubMode )

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

declared a fill timeout alarm

LEAHI-DD-FIRMWARE-LDT-3103-1 13 Mar 2026

Looks the fields are empty and misaligned. fill as needed.

LEAHI-APPLICATION-LDT-3413-1 13 Mar 2026

BN APPROVES.

LEAHI-APPLICATION-LDT-3516-1 13 Mar 2026

BN APPROVES.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Are we going to restore this or not?

LEAHI-DD-FIRMWARE-LDT-3352-1 13 Mar 2026

Remove extra blank line.

LEAHI-TESTSUITES-LDT-3060-1 12 Mar 2026

After removing this line of code, test script got failed one time, So I keep this line of code

LEAHI-DIALIN-LDT-2428-1 16 Oct 2025

Do we not need to do this anymore?

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Removed all unused imports.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Removed o_Overlay and o_treatmentHome objects.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

Are we not supporting sub mode requests for these modes?

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed the top portion.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Keep this blank line.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Removed

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

updated.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Updated as suggested

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

changed

LEAHI-DD-FIRMWARE-LDT-3103-1 13 Mar 2026

done changed it.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

should be tmp_RangeBar

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

Remove top comment portion

LEAHI-TD-FIRMWARE-LDT-1840-1 13 Mar 2026

Removed

LEAHI-TD-FIRMWARE-LDT-3215-1 17 Mar 2026

Updated

LEAHI-DIALIN-LDT-2352-1 16 Oct 2025

done

LEAHI-DIALIN-LDT-2352-1 16 Oct 2025

done - as part of this comment, the piston pump module was deleted

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

Add blank line after declarations.

LEAHI-TESTSUITES-LDT-1218-1 17 Oct 2025

Added the opmode as suggested.