Comment Search

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

I don't think we need to check for rejected here. If we rejected params, UI will have to send us new params until we accept them.

Remove the old 0xA008. There can only be one message ID.

Not a comment to be done right now.
But better to create arrays of test data on top of the function/file, loop through them, and call the function (verify_td_and_dd_versions) to use those.
So we can more easily add multiple test data cases later to cover more edge cases.

moved to shared file and update to have the object as a parameter

added

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

for consistency with all the other branches please use setObjectText isntead.

No Action For Now:
Same for the vError param:
https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76762

move to a common functions file

What is this file used for?
And please add a brief description for the file comment.

Now using setText(obj, text) method and moved to configuration folder utility.py file

Now findObjectById(parent, id): method is moved to configuration folder utility.py file and get_aut_version(aut_path): method is moved to configuration folder application_init.py file

moved to shared file and update to have the object as a parameter

Need to delete this unit (ModeTxParams.c/.h). Also need to remove the mode from the modes enumeration and from OperationModes.c.

Remove extra blank lines.

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

The way we verify is that the o_PreTreatmentButton is only enabled when they are so testing that it is first enabled then mouse click the button then from fw send the td.td_Treatment_Parameters_Validation

We should use "min" for minutes and not "mins".
Same for "hrs" => "hr".

The view classes are QObject, and they already have an internal timer that you can start and use in the timer event.
Therefore, this block of code needs to be moved to the timerEvent.

I have created a story as an enhancement to the date and time for the following:

1. Since the SW Board is the only reference for the clock, we now need to send the date and time to both the TD and DD every second as a broadcast message
   • That message should be on a general channel so both get it instead of two separate messages.
   • If SW won't update the TD every second, and with a different epoch, TD will raise an alarm
     • We only need to know, but SW does not need to do anything about it
     • The Alarm infrastructure will automatically handle it
     • If disconnected, TD will play the alarm sound and turn on the alarm light.
2. While we are sending the epoch as broadcast every second, and TD will raise an alarm if we don't, we need to get rid of the two requests, response messages, and send that epoch every second broadcast.
3. As has been mentioned above, we need to update the disabled date and time on NTP
   • When switched to NO NTP, stop updating.
4. A timezone needs to be added to the Date and time screen, since we already have NTP, so that we can update by timezone.
5. Another comment: don't the datetime conversion, 'toString' function is slow, and that we can pass integer values instead, since we are going to use it every second?

LDT-2909: Service - SW - 01 - Enhancement - FW epoch Broadcast, TimeZone - R&I
LDT-2923: Service - SW - 02 - Enhancement - FW epoch Broadcast, TimeZone - Q&R

We still need this if statement.