Comment Search

Done

Fix spacing, align "<<".
Should all of the M valves come first?
I didn't see an M7 valve in other contexts. Is M7 obsolete?

Do you mean to delete this function?

Are pressure sensor temperatures the only temperatures that get filtered? Why aren't we filtering all temperatures?

Added suite.conf file.

The test suite is missing an update to the suite.conf file that adds your test case to the test suite. Please push the file with the addition of your test case

after the mouse click and before the exporty_log_status line is the only place we need utils.waitForGUI(1) as we need to wait for the progress message to appear

add braces for slots

They are initialized in the valves driver.

Done

Are these just temporarily being published for tuning?

expand brances

not aligned

Remove extra blank line.

???

fix acid concentrate popup notification margins

Ok, but then I think the valves controller should be calling a function in this driver to accomplish this kind of thing since it's a driver level activity.

1. Please add the comment block as discussed
2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1220

function onAdjustmentTriggered ( vValue ) {

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

revert this and make consistant with all other labelunitcontrainers

add comment for why

TRIGGER( bool , adjustment , 0 )
instead

Remove and wait for staging changes.

This is only temporarily showing the FPGA bits of BLD status for debugging purposes.