corrected the invalid syntax and added the space between the function
Add a comment: result already FALSE - do nothing more for modes that do not support jump to sub-mode.
Are these coming back? If so, add TODO comment to restore later. If not, delete them.
updated.
Done.
Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.
Remove blank line and comment saying we're not doing anything (because now we're doing something).
Is bicarbonate also a conversion factor?
Is this supposed to be difference in pressure, not the spent dial pressure?
Remove blank line.
please Alignment the comments
is documentation correct ?
So we have all temp sensors getting averaged now, right? So should we have one get function that takes a sensor ID as param?
Remove this.
I don't think these coefficient access functions need to be public. Consider making them private.
Add blank line after declarations.
Remove extra line.
Why are we signaling syringe load confirmed here?
this would be out of scope of the original ticket. https://diality.atlassian.net/browse/LDT-4733 Looking at the debug data, this alarm would still trigger. Voltage values are still reporting 0.
Do these states need to be public?
Where is this being called? Should be called from pre-treatment init I think.
Updated.
This will be implemented in a subsequent story.
Align "="
Verified that placement is correct.
added existing objects to names.py file.
Nicholas Ramirez Could you please recheck, I don't see the updated change.
updated
are we using this variable, if not, can we remove across the file?
RESOLVED.
Fix alignment of "=".
RESOLVED
Close start on confirm to go back to main treatment.
Remove spaces before "=" or align "=".
done.
Added
I think we should just have == here so that we only warn them once.
Name in brief doesn't match function name.
The configuration is from Denali. Please lets port in what we are using into a new one as part of this test suite
This is a structure, not an enumeration.
is this a python lib or is this made by us?
Added new configuration file utility.py for Leahi.
Please make keep all existing object as they are required for the other test cases.
align each parameter as well please
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
