Comment Search

Done

I would prefer to keep it here, as the start state (DRY_BICART_START_STATE) is always executed when the fill bicart flag (dryBiCartFillRequested) is not set. There are other execs, say fill chamber (execBicarbChamberFillMode) mode controls D80 in its sub states. So, not two execs controlling same valve. Once we identified where all modes using these execs, will come up with signals to avoid such scenarios.

okay acknowledged

Please put comments for your division number.

Please align.

does not match function in stagin please verify and update

Remove extra blank line.

reason is given has one

Added.

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

done

added. thanks!

Is this temporary?

END_POS_FIELD_19?

Test script is updated as per suggestion

Fixed.

You don't need the if statement. The override function will check it automatically.

Should use existing override payload structure (the one with the index) located in TestSupport.h.
Add an enum in this unit for the 5 DD treatment parameters so you can interpret the index field of the message payload to find the specific parameter that is being overridden.

Changed the comments

publish filter flush status , add other important data , inlet pressure etc

Fixed.

I don't see this function resetting Tx params. Probably a good idea to do that, so add call to reset.

can we make this a more general method and put in a shared file and update throughout.. updatet to something like

def setText(obj, text):
    obj["text"] = text
    return obj:

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

another mouseClick(waitForObject(confirmButton)) after fw validates parameter is needed