•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

add changing the the opmode first too.. td.td_operation_mode( TDOpModes.MODE_TREA.value, 0 )

LEAHI-TESTSUITES-LDT-1218-1 15 Oct 2025

I know in the solution infusion i used this but this button is going to be removed so can we do instead:

td_interface.td_operation_mode( TDOpModes.MODE_TREA.value, 0 )
td_interface.td_tx_state(
TDTreatmentStates.TREATMENT_DIALYSIS_STATE.value ,
0 ,
0 ,
0 ,
0 ,
0 ,
0 ,
0 ,
0 ,
0
)

TD-LDT-1886-7 16 Oct 2025

Replace current with torque.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Are we going to restore this or not?

LEAHI-DD-FIRMWARE-LDT-3352-1 03 Apr 2026

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

LEAHI-DIALIN-LDT-1886-1 16 Oct 2025

I don't think we have motor current. We're getting torque instead. Just replace current with torque.

LEAHI-DIALIN-LDT-3629-1 12 Mar 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Can we delete this commented out line?

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Updated as suggested.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

I think this validate function needs to know the requested mode as well - should have 2 params.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Renamed the test case as tst_main_treatment

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Aligned.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Remove if not being used

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Please align all as following:

        { "arterial_pressure"    : 100,  "arterial_limit_low" : -300, "arterial_limit_high" : 120, 
          "venous_pressure"      : 140,  "venous_limit_low"   : -100, "venous_limit_high"   : 250,
          "pressure_limit_state" : 2,    "tmp_pressure"       : 250 , "tmp_limit_low"       : -400 , "tmp_limit_high" :  200 },
LEAHI-DD-FIRMWARE-LDT-3630-1 12 Mar 2026

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

dialyste_tmp_title_Text

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Please remove o_Overlay and o_treatmentHome as they are not used

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

If this is specific to only your test case then move this in the test case

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

source removed

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Match properties from Denali where you can. The priorities should both be HIGH. The rank for the warning should be a higher number. The alarm should be TRUE for no resume and no rinseback. So, I know these properties aren't correct.
One thing I don't think we should copy from Denali though - I think the warning should not be TRUE for the STOP property so that we stay in blood prime state.

LEAHI-DIALIN-LDT-2352-1 16 Oct 2025

Update the comments - Valve 4, D21

LEAHI-DIALIN-LDT-2352-1 16 Oct 2025

This message ID (0xF0) is no longer valid? and remove empty spaces.

LEAHI-TESTSUITES-LDT-1057-1 16 Oct 2025

align "unamed" to others

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

Assign bloodPrimeStartMS here to mark start of pause.

LEAHI-TESTSUITES-LDT-1218-1 17 Oct 2025

Removed all waitForGUI commands.

LEAHI-APPLICATION-LDT-3698-1 16 Mar 2026

Add '#' to start of line?

LEAHI-TD-FIRMWARE-LDT-1903-9 11 Mar 2026

You are calling setAirPumpState in if and else. Consider just calling once after the if/else.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Align comment.

LEAHI-DIALIN-LDT-2428-1 17 Oct 2025

after some thought, test_training.py will need to know where leahi dialin is if leahi_dialin is not installed in the venv. This is okay

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

remove all the waitForGUI

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

the variable name is not "temp" it is "tmp" for Trancememberance. Please fix all object names that are "temp" and update to "tmp" uppdate comments from "temperature" to "Trancememberance"

TD-LDT-1886-7 16 Oct 2025

BloodFlow.c should have a public get function for torque like other overrides.

LEAHI-RO-FIRMWARE-LDT-1773-1 16 Oct 2025

I think this should be initialized to zero in case some bits are unused.

LEAHI-DIALIN-LDT-1886-1 16 Oct 2025

I think we should replace motor current with torque instead of adding torque as new field.

LEAHI-DIALIN-LDT-2352-1 16 Oct 2025

done

LEAHI-DIALIN-LDT-2352-1 16 Oct 2025

Update the comments = Valve 7, D26.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

rename test case to tst_main_treatment.. The name looks like this is only testing pressure when we test all the other items as well

LEAHI-DD-FIRMWARE-LDT-3603-1 12 Mar 2026

Changed and left them as static, as we don't need these outside this unit

LEAHI-DIALIN-LDT-3629-1 12 Mar 2026

added Todo comment

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Can we delete this commented out line?

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

currentMode is an input.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

if ( TRUE == result )

LEAHI-APPLICATION-LDT-3574-1 12 Mar 2026

update to c++ method

LEAHI-DIALIN-LDT-2655-1 16 Mar 2026

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Aligned

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

done.

LEAHI-APPLICATION-LDT-3698-1 16 Mar 2026

Remove commented out lines?

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

4 byte reg.

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Add blank line after declarations.