•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

add braces for slots

TD-LDT-1886-7 23 Oct 2025

The valves are initialized in the valves driver in the first state.

TD-LDT-1886-7 23 Oct 2025

They are initialized in the valves driver.

TD-LDT-1886-7 23 Oct 2025

1760 is a nominal value. The driver will keep adding steps if 1760 worked for the first time. These values are suggested by the hardware team.

TD-LDT-1886-7 23 Oct 2025

Done

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

Removed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 21 Oct 2025

Are these just temporarily being published for tuning?

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

-5

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

expand brances

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

hard code 50. try and only use icon size

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

not aligned

LEAHI-TESTSUITES-LDT-1057-1 23 Oct 2025

Please update to add in the real way to get to the settings screen
1. Start up application
2. Change opmode to standby
3. Select Settings
4. Select Export logs.

Please Update on every time applications opens

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

???

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

change to _vitalCountdown

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

fix acid concentrate popup notification margins

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

When are we planning to remove this?

TD-LDT-1886-7 23 Oct 2025

Ok, but then I think the valves controller should be calling a function in this driver to accomplish this kind of thing since it's a driver level activity.

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

Removed. Thanks

LEAHI-TESTSUITES-LDT-1218-1 24 Oct 2025

1. Please add the comment block as discussed
2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1220

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Make height consistent with LabelUnitContaier in Rx.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

function onAdjustmentTriggered ( vValue ) {

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

remove

TD-LDT-1886-7 23 Oct 2025

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

fix icon to show no whitespace

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

revert this and make consistant with all other labelunitcontrainers

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

group slots at the bottom

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

add comment for why

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

Change to start in treatment only

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

TRIGGER( bool , adjustment , 0 )
instead

TD-LDT-1886-7 23 Oct 2025

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Remove and wait for staging changes.

TD-LDT-1886-7 23 Oct 2025

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

This is only temporarily showing the FPGA bits of BLD status for debugging purposes.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

revert this back and left align and clip

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

remove

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

adjustment ( true );

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Change this to visible: _root.unitText.length > 0

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

This is only temporarily showing the FPGA bits of BLD status for debugging purposes.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

remove

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

if ( enableBPCuff ) then only _root.open ()

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Use showUnit.

LEAHI-TESTSUITES-LDT-1057-1 24 Oct 2025

1. Please add the comment block as discussed
2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1059

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Verify why size changed between here vs original usage.

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Removed showUnit and are now basing visibility on length of the unitText.

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

The height of the LabelUnitContainers in Rx are calculated based on the size of the area and number of rows, so there is no hard coded value.

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Updated to use default component size.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

Addressed points 1 and 2.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

Updated as suggested.