•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

add comment for why

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

Change to start in treatment only

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

TRIGGER( bool , adjustment , 0 )
instead

TD-LDT-1886-7 23 Oct 2025

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Remove and wait for staging changes.

TD-LDT-1886-7 23 Oct 2025

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

This is only temporarily showing the FPGA bits of BLD status for debugging purposes.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

revert this back and left align and clip

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

remove

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

adjustment ( true );

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Change this to visible: _root.unitText.length > 0

LEAHI-DD-FIRMWARE-LDT-2662-1 23 Oct 2025

This is only temporarily showing the FPGA bits of BLD status for debugging purposes.

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

remove

LEAHI-APPLICATION-LDT-2686-1 24 Oct 2025

if ( enableBPCuff ) then only _root.open ()

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Use showUnit.

LEAHI-TESTSUITES-LDT-1057-1 24 Oct 2025

1. Please add the comment block as discussed
2. Upload the test results onto https://diality.atlassian.net/browse/LDT-1059

LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Verify why size changed between here vs original usage.

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Removed showUnit and are now basing visibility on length of the unitText.

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

The height of the LabelUnitContainers in Rx are calculated based on the size of the area and number of rows, so there is no hard coded value.

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Updated to use default component size.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

Addressed points 1 and 2.

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

Updated as suggested.

LEAHI-DIALIN-LDT-2658-2 27 Oct 2025

Dara Navaei please advise

LEAHI-TESTSUITES-LDT-1218-1 28 Oct 2025

Added test.startSection() and test.endSection() for the Pressures.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-TESTSUITES-LDT-2174-1 05 Nov 2025

Please remove all object that are not used for treatment parameters

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Shouldn't it be better defined in utility.py, or application_init.py?

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

why is this line here?

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Could you remind me what the difference is between this one, "exportLogsText", and the one in line 29, "settingsHomeExportLogs".

LEAHI-TESTSUITES-LDT-1057-1 27 Oct 2025

Do not use "text" to identify the object; once translated, it cannot be found anymore.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Fix objectName.

DG-DENBUG-327-1 30 Oct 2025

Done

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. Thanks!

LEAHI-TESTSUITES-LDT-1057-1 29 Oct 2025

The Objects have been updated for clarity:

exportLogsText → o_ExportLogsPageTitleText (refers to the Export Log page title)

settingsHomeExportLogs → o_DeviceSettingsTitleText (refers to the Export Log text on the Device Settings page)

LEAHI-RO-FIRMWARE-LDT-2116-1 03 Nov 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Do we need to add any functions to Comm.c?

LEAHI-RO-FIRMWARE-LDT-2116-1 29 Oct 2025

Space between if and (.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

It is so important that the simulator should never run in parallel with your tests.

LEAHI-DD-FIRMWARE-LDT-2004-1 04 Nov 2025

Should this be in the Teensy driver? Why is it here?

LEAHI-TESTSUITES-LDT-1218-1 23 Oct 2025

For this lets not get 2 of the same object. For this if the "text" property that is going to be tested get the parent object instead and use that to test..

try:

 treatmentTimeNotificationBarSmall = {"container": mainTreatmentScreen, "objectName": "notification", "type": "NotificationBarSmall"} 


then use that "text" property of that parent object to test

LEAHI-TESTSUITES-LDT-1057-1 30 Oct 2025

That is fine for now, but please think ahead and move it as soon as you have used it elsewhere.
Also, by moving it to a more general place, others will notice and use it, instead of duplicating.

LEAHI-APPLICATION-LDT-2666-1 28 Oct 2025

Add '_' to objectName.

LEAHI-APPLICATION-LDT-2666-1 30 Oct 2025

Updated.

LEAHI-RO-FIRMWARE-LDT-2116-1 29 Oct 2025

Keep blank line between functions.

LEAHI-APPLICATION-LDT-2686-1 28 Oct 2025

RESOLVED