Add blank line between declarations and rest of code.
We ensured that simulator was closed while executing the script.
RESOLVED
Updated.
I would move these navigations into a py file like navigation.py to ve used in other places.
Space between if and (.
TargetDutyCycle is F32 override
Make 10000 a #define.
Add a Private Definitions banner between includes and private definitions.
updated all objects names started with o_.
removed the line "app_context = None".
Update objectName.
fixed. Thanks!
temporary. Reverted back to original publishing data.
removed the method def_stop_application(), because not using it in test script.
Remove bindng.
Remove binding.
750?
750 now?
I mean, don't you think Sarina/Eliza still want this test config option? Why did you comment it out?
updated combobox to o_LogTypeComboBox.
Sean Nash the override functions other than the standard override functions, (e.g. broadcast interval) are implemented as per needed.
It is ok for now, but from lines 11 to 19, there are still some object names that need to be refactored. Will be mentioned in later reviews,
line 144 should have been removed as we discussed.
Updated to use common height from Variables.qml
Do we need to shift CRC bits to lsb position?
set to 750 for all controlled flows.
Added comment block and uploaded test report onto Jira.
why "-3"? Please put a comment like line @58.
Why are we sending Teensy board a string command? I thought we changed Teensy interface to be binary.
Why string?
Add blank line between declarations and function code.
Add blank line before return statement.
Is sending of ACK msg needed here?
Why are we doing pre-increment instead of post-increment? I don't think it matters in for loop, but this looks non-standard to me.
What are we doing with fpReason?
Is it still needed? If so, when do we expect it can be removed?
Can we remove it now (before we merge to staging)?
Done
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
