•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line before return statement. ( throughout this unit )

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed the unused import

LEAHI-TD-FIRMWARE-LDT-4029-1 09 Jul 2026

What alarm is this? It doesn't look like you've added a new alarm. This is one of the reserved (unused) alarms that UI s/w might use.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Aligned

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

changed and updated all the other places.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Should assign a local variable to this equation and then return the variable.
Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int.
Also, do we want to do any rounding when converting float to integer?

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

Remove comment.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Added

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

updated.

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

BN Approves

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

SQ APPROVES

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

SQ APPROVE

LEAHI-DD-FIRMWARE-LDT-3628-1 17 Mar 2026

Remove typecast.

LEAHI-DD-FIRMWARE-LDT-3352-1 13 Apr 2026

Done.

LEAHI-DD-FIRMWARE-LDT-2008-1 14 Apr 2026

fixed

LEAHI-DD-FIRMWARE-LDT-2008-1 10 Apr 2026

Now we don't need this macro ?

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Service record not yet available. Comment out with TODO

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

I would keep this stuff commented out until disinfection is implemented.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Add blank line between declarations and code.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

removed the unused variables.

LEAHI-DD-FIRMWARE-LDT-3749-2 10 Apr 2026

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

LEAHI-TESTSUITES-LDT-1057-1 20 Oct 2025

The test suite is missing an update to the suite.conf file that adds your test case to the test suite. Please push the file with the addition of your test case

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

deleted

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN APPROVES

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

removed

LEAHI-TD-FIRMWARE-LDT-3126-2 13 Mar 2026

Align with others (after U32).

LEAHI-DIALIN-LDT-2662-1 20 Oct 2025

done - reordered list to match current FP implementation

LEAHI-APPLICATION-LDT-3698-1 17 Mar 2026

added

LEAHI-DIALIN-LDT-2662-1 20 Oct 2025

done - reordered list to match current FP implementation

LEAHI-TD-FIRMWARE-LDT-1903-9 11 Mar 2026

Add space between if and (

TD-LDT-1886-7 20 Oct 2025

Done

TD-LDT-1886-7 20 Oct 2025

Done

LEAHI-TD-FIRMWARE-LDT-4040-1 10 Jul 2026

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

TD-LDT-1886-7 20 Oct 2025

Done

LEAHI-DD-FIRMWARE-LDT-2008-1 14 Apr 2026

both drivers need to be initialized since we dont know what Beta unit we are running until the FW receives test configuration(s).

TD-LDT-1886-7 20 Oct 2025

Done

LEAHI-DIALIN-LDT-2662-1 20 Oct 2025

Should M12 come after M4?

LEAHI-DIALIN-LDT-2662-1 20 Oct 2025

Fix spacing, align "<<".
Should all of the M valves come first?
I didn't see an M7 valve in other contexts. Is M7 obsolete?

LEAHI-DD-FIRMWARE-LDT-2008-1 14 Apr 2026

fixed

LEAHI-DD-FIRMWARE-LDT-2662-1 21 Oct 2025
TD-LDT-1886-7 20 Oct 2025

Do you mean to delete this function?

LEAHI-DD-FIRMWARE-LDT-2662-1 21 Oct 2025

Done.

LEAHI-DIALIN-LDT-2658-2 22 Oct 2025

Are pressure sensor temperatures the only temperatures that get filtered? Why aren't we filtering all temperatures?

LEAHI-TESTSUITES-LDT-1218-1 21 Oct 2025

Added 2 tests for "Treatment Paused" and "Treatment Complete".

LEAHI-TD-FIRMWARE-LDT-4029-1 14 Jul 2026

171

LEAHI-TESTSUITES-LDT-1218-1 21 Oct 2025

Added suite.conf file.

LEAHI-DD-FIRMWARE-LDT-2662-1 21 Oct 2025

HIGH_START is 0, so if != to HIGH_START, count will always be > HIGH_START. So pointless to have that condition in this if statement.

LEAHI-TESTSUITES-LDT-1218-1 20 Oct 2025

The test suite is missing an update to the suite.conf file that adds your test case to the test suite. Please push the file with the addition of your test case