•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-1078-1 12 Nov 2025

I have deleted strings.py file from Bitbucket branch feature/LDT-1078-Device-Settings-Information-Version

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

This works. A few other qml files use this version of the import

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

IMPORTANT!!!
Please test this on the device.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Can you help me understand why we did not use the DeviceController attribute to call the datetime set script?
Or modify this function to use that design?

LEAHI-DD-FIRMWARE-LDT-2004-1 13 Nov 2025

Put in #ifdef.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

I do not see the script's exit code in the date_time_set.sh script.
https://devapps.diality.us/cru/#LEAHI-SW-SCRIPTS-LDT-2727-1CFR-76860

TD-LDT-1886-7 10 Nov 2025

None?

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

👍 Will do all these in the enhancement story

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

updated to now change result to FALSE if we get a rr that is not NONE

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

TD-LDT-1886-7 10 Nov 2025

Then put an #if 0 around this if and add a TODO comment to implement the test configuration.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

updated to store in file sysetm

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

is this a typo?

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

fixed. thanks

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

added comment

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

the content for each page is now set to this container which will handle the margins for the container so all componenets using the SettingsBase will have the same margins and I do not have to specify them left, right, bottom in each of them.. I have done the same thing for other components that act as a container

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Shouldn't it check the password from FS (Service.conf)?
If so, FS interaction is missing.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

These two lines can be moved to the geteopochUTC.

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

error count or reading temperature?

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

UNINITIALIZED?

LEAHI-DD-FIRMWARE-LDT-2004-2 11 Nov 2025

move all structure alignment in to a single block #pragma pack(push,1) and #pragma(pop)

LEAHI-TESTSUITES-LDT-2174-1 11 Nov 2025

Modified the conditions as per your suggestion

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

yes typo and fixed

HD-DENBUG-328-1 12 Nov 2025

Please add the comments mentioning the reason/purpose for the checking fluid level timeout alarm?

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

why the rowcount is real?

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Do not use the 'const &' on basic types (int, bool, char, ....).
The result is even worse and is not worth it.
But please still keep the alignment.

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

please keep the saline bolus ones that are already in staging. Remove the main treatment objects that were added in a different branch/story. Anything in staging that existed before must still exist

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

fixed. thanks!

HD-DENBUG-328-1 12 Nov 2025

Done

LEAHI-TESTSUITES-LDT-1650-1 11 Nov 2025

remove the strings.py file from the project now that we are not going to be using it.

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

Why?

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

Why here?

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

#ifdef

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

space b/w '}' and 'Conductivity'. seen other places too in the file, please check and update.

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

LEAHI-TESTSUITES-LDT-1650-1 18 Nov 2025

Add get_aut_version function and getting UI version using subprocess

LEAHI-TESTSUITES-LDT-1650-1 19 Nov 2025

can you get the path relatively and not hard coded. This path is specific to your VM

LEAHI-TESTSUITES-LDT-1078-1 18 Nov 2025

Add get_aut_version function and getting UI version using subprocess

LEAHI-TESTSUITES-LDT-1078-1 18 Nov 2025

updated

LEAHI-DD-FIRMWARE-LDT-2662-1 14 Nov 2025

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

LEAHI-DD-FIRMWARE-LDT-2662-1 14 Nov 2025

No I removed it.

LEAHI-DD-FIRMWARE-LDT-2662-1 14 Nov 2025

Done

LEAHI-SW-SCRIPTS-LDT-2727-1 17 Nov 2025

Any specific reason this file is not refactored to the new standard?

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

memcpy is unsafe function. check if there is safer version of memcpy like memcpy_s

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Do not use the magic number.

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

give comments for all parameters

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Always check the return value of snprintf to detect potential errors