•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Why did the logic change?
The order should be to fill in the first column, then go to the next, and it should not be by row.

TD-LDT-1886-7 07 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

Done

LEAHI-SW-SCRIPTS-LDT-2727-1 13 Nov 2025

added the checks and graceful exit

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Every time you use " * someValue ", please add a comment explaining why.
@100, @101, @102 as well.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Where in the design do you store the new password?

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

Align the comments in fixed indentation throughout the file.

DIALIN-DENBUG-328-1 06 Nov 2025

I thought default was 5?

LEAHI-TESTSUITES-LDT-2174-1 07 Nov 2025

Removed all the objects which are not used in the treatment parameter and kept objects which are in staging

LEAHI-TESTSUITES-LDT-2174-1 07 Nov 2025

Removed the text properties in the object

TD-LDT-1886-7 08 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

None?

LEAHI-SW-SCRIPTS-LDT-2727-1 12 Nov 2025

Also, regarding the above format, each script needs to check whether a command fails and gracefully exit either way.

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

changed to int

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated logic so the grid view has an equal number of rows depending on the total number of visible items.

Before row count was hard coded to 6 so if there was ex. 8 items the left column would show 6 and the right 2.. Updated so the gridview will look as even as possible.

I hard coded the column to 2 columns since the design has 2 columns and added logic to the row count to make the 2 columns equal

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated and added to fonts

LEAHI-SW-SCRIPTS-LDT-2727-1 13 Nov 2025

updated and checked and works. thank you

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Fonts.qml

LEAHI-TESTSUITES-LDT-2174-1 07 Nov 2025

Removed the object Which is not being used

LEAHI-TESTSUITES-LDT-1650-1 10 Nov 2025

I have pushed utility.py file

TD-LDT-1886-7 10 Nov 2025

documentation error- is it transition start time ?

HD-DENBUG-328-1 12 Nov 2025

RESOLVED IN CODEWALKTHROUGH

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

updated

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

updated to now change result to FALSE if we get a rr that is not NONE

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

this method removed but updated elsewhere

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-TESTSUITES-LDT-1078-1 11 Nov 2025

remove this file and port anything needed into config.py for consistency just like we are doing in http://devapps.diality.us:8060/cru/LEAHI-TESTSUITES-LDT-1650-1

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

Move to ConductivityTeensy.c?

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

#ifdef

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Why exposed?
Shouldn't the SettingsBase decide where the children must anchor, or locate?

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

For signals and slots as we tlaked use blocks of

onSomething: {
   aFunctionCall()
}


Unless there are multiple similar calls that need alignment in one line.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Please make vDateTime optional; if not set, return the current datetime epoch.
It is better to use the 'timeEvent' (right now, onSetDateUIFinished).

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Align '_', and '=' please.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Same as https://devapps.diality.us/cru/#LEAHI-APPLICATION-LDT-2727-1CFR-76783

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

Add the comments for coefficients. bring a top-level comment explaining the formula where these coefficients are being used.

TD-LDT-1886-7 08 Nov 2025

The checks are back in a generic function.

LEAHI-DD-FIRMWARE-LDT-2004-2 11 Nov 2025

use uniform naming convention. All other places used conductivity

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

This should be FS (file system), not the OS, unless you run a script and it is being executed by bash/sh.

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

reworked to use the request functions we have in the respective op modes. They check the standby constraint

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Why do we need to remove this?

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

#ifdef USE_TEENSY_CONDUCTIVITY_DRIVER

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

Remove extra line.

LEAHI-TESTSUITES-LDT-1650-1 12 Nov 2025

I have deleted strings.py file from Bitbucket branch feature/LDT-1650-headerbar-information

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

updated

LEAHI-APPLICATION-LDT-2727-1 13 Nov 2025

this was existing code.. Updated to use the DeviceController and made updates accordingly. And Tested and still works

LEAHI-SW-SCRIPTS-LDT-2727-1 13 Nov 2025

Updated to follow format

LEAHI-SW-SCRIPTS-LDT-2727-1 12 Nov 2025

Please use the following commands from NetworkManager utilities, since in Leahi we are not using the wpa_supplicant directly:

nmcli connection delete DilaityIoT 
nmcli connection delete $(nmcli -t -f NAME connection show --active) 
TD-LDT-1886-7 08 Nov 2025

Done

TD-LDT-1886-7 10 Nov 2025

I don't see this input used in function.