Comment Search

updated

align the comment.

Remove (void)

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

should we move the initialization in the init function?

Remove blank line.

macro should be before ==

We should go to dry self test state. Why did this change to Rx state?

Add comment to align with the rest of the implementation.

Add comments to right.

Change this to work for any state (passed as parameter).

do you need to add global bloodSetAutoEject before this line?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

function onAdjustmentTriggered ( vValue ) {

I think most of what's happening in this state should be done in a function in RotaryValve.c that we call from here (since it's doing very low level things that the driver should be doing).

Please add comment. if it is not being used, delete it.

RESOLVED.

added

RESOLVED.

Response needs to be sent immediately (in message handler function). This is too late.

Add space between ( and ?

Local declarations should come first - move up above reset function above.

I checked with Vinay. It is not too early. The plan is to start DD pre-generation immediately after the Start Treatment request, while DD waits for IOFP/FP to complete permeate generation before entering Pre-Treatment.

please break the line in two or more.

add a space before and after index 'i'