•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2004-1 01 Dec 2025

Why two output lines?

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Should we be calling get function in monitor instead of driver here?

LEAHI-TESTSUITES-LDT-1802-1 02 Dec 2025

updated. Removed header bar information and device settings information objects

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Add space before );

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs throughout this unit.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

isFlushComplete looks like an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Update inputs/outputs.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Should be 2 blank lines before/after test banner.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

roRejectionRatioTankFill is also an output.

LEAHI-DD-FIRMWARE-LDT-2936-1 01 Dec 2025

Add blank line between declaration and rest of code in scope.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Missing param line in function header.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Flag for rejection not needed?

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

comment should start with Capital letter ?

LEAHI-DD-FIRMWARE-LDT-2004-1 01 Dec 2025

All cases seem a little off on indents, especially this one.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Modified. Thanks

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

This unit is not a mode. It is replacing a mode with a service.
Change to "Treatment parameters unit provides validation and confirmation handling for treatment parameters from the UI."

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Done in if condition, that block of code will be executed only when the denominator value is greater than 10

LEAHI-TESTSUITES-LDT-1650-1 03 Dec 2025

ive noticed this common method being used in other test cases. If its a general method that is used throughout please move outside in a shared file and call from there. Please update other repositories that use this as well.

LEAHI-TESTSUITES-LDT-2174-1 04 Dec 2025

remove this and use set_parameter_type()

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

By mistake, I forget to remove

LEAHI-APPLICATION-LDT-2957-1 16 Dec 2025

RESOLVED.

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Yes, I used MSG_ID_AVAILABLE_2.

LEAHI-DD-FIRMWARE-LDT-618-2 03 Dec 2025

details should have specific lines (e.g. Inputs and Outputs). Generic function description should be in the brief section above.

LEAHI-TESTSUITES-LDT-1078-1 05 Dec 2025

Now using setText(obj, text) method and moved to configuration folder utility.py file

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

Moved this function into shared file

LEAHI-DD-FIRMWARE-LDT-2030-2 05 Dec 2025

Do not mix static and public function, let all public function on top and static bottom, except override and test functions

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Added

LEAHI-TESTSUITES-LDT-1454-1 09 Dec 2025

Renamed the function set_Object_Text

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

I don't see any get functions. I think we need to copy from ModeTxParams.c.
Let's make sure we've copied all needed functions from ModeTxParams.c and then don't forget to delete ModeTxParams.c/.h.

LEAHI-DD-FIRMWARE-LDT-2936-1 09 Dec 2025

Change comment from 3 to 5 minutes to match code.

LEAHI-TESTSUITES-LDT-1802-1 05 Dec 2025

Please add the test case to the suite.conf

LEAHI-TESTSUITES-LDT-2174-1 05 Dec 2025

add comment block to all functions that are missing

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

yes good catch. updated

LEAHI-TESTSUITES-LDT-2174-1 11 Dec 2025

Remove the delay

LEAHI-APPLICATION-LDT-2825-1 17 Dec 2025

add message id and number of parameters

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Put quadratic and linear terms in parentheses.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Deleted.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Yes, I deleted.

LEAHI-TESTSUITES-LDT-1802-1 18 Dec 2025

Now using get_object_color, get_object_source_path, get_object_text method and moved to configuration folder utility.py file

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

removed

LEAHI-RO-FIRMWARE-LDT-2116-1 18 Dec 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-3000-1 18 Dec 2025

updated to older design

LEAHI-DIALIN-LDT-2998-1 18 Dec 2025

Updated

LEAHI-APPLICATION-LDT-3000-1 17 Dec 2025

only update size on EndTreatmentDialog and leave this size as is. and fiz settings confirm dialogs

LEAHI-TESTSUITES-LDT-2278-1 16 Dec 2025

sorry "reasom" is mispelled.. should be "reason"