•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2666-1 24 Oct 2025

Verify why size changed between here vs original usage.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

This is not extra blank line its a line for TASK_GENERAL_INTERVAL )

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Let's remove this commented line.

LEAHI-DD-FIRMWARE-LDT-3978-1 26 Apr 2026

Why are you redeclaring result? This assignment will not survive outside of the if statement.

LEAHI-DD-FIRMWARE-LDT-3978-1 27 Apr 2026

Align the value declaration indentation.

LEAHI-APPLICATION-LDT-3757-1 16 Apr 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-9 16 Apr 2026

Its static function and not used by external API to pass the wrong id.

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

Do we need to reset authStartTime here before we go to next state?

LEAHI-APPLICATION-LDT-2707-1 15 Apr 2026

Create new function and leave this one alone.
Name:trendsEventTitleLog.

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

updated

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Remove bloodSittingTimerCtr

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Remove Alarm

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break the comment in two lines

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

break this line

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

StateTxRecirc should be above StateTxRinseback

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

Add presUFRateMlMin to outputs

LEAHI-TD-FIRMWARE-LDT-4040-1 23 Jul 2026

please add a TODO or remove commented code.

LEAHI-DD-FIRMWARE-LDT-4500-1 24 Jul 2026

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

LEAHI-APPLICATION-LDT-3800-1 17 Apr 2026

change to userMode

LEAHI-TD-FIRMWARE-LDT-2240-1 26 Apr 2026

Put positive case first ( TRUE == ...), then alarm and reject cases.

LEAHI-APPLICATION-LDT-3932-1 23 Apr 2026

remove spaces

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Not necessary to request fault mode. Just set alarm fault property to TRUE.

LEAHI-TD-FIRMWARE-LDT-1886-2 22 Apr 2026

Add a blank line after declaration(s) for a little separation.

LEAHI-DD-FIRMWARE-LDT-4410-3 23 Jun 2026

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

LEAHI-TD-FIRMWARE-LDT-4149-1 20 Jul 2026

Fixed

LEAHI-TD-FIRMWARE-LDT-4063-1 21 Jul 2026

add a blank line above

LEAHI-TD-FIRMWARE-LDT-4049-1 22 Jul 2026

Our TODO comments are all CAPs.

LEAHI-TESTSUITES-LDT-3946-1 23 Jul 2026

added global patientDisconnectConfirmRequest as per comment

LEAHI-TD-FIRMWARE-LDT-4040-1 21 Jul 2026

Add TODO to these comments.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Just have a comment here that says "Ok - do nothing."

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

I think we should have handle functions that return next state for each of these cases (just like mode state machines).

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Restore this.

LEAHI-DD-FIRMWARE-LDT-3735-1 27 Jul 2026

Not needed because the retry mechanism is going to be deleted in the next ticket.

LEAHI-TD-FIRMWARE-LDT-4149-1 27 Jul 2026

Remove obsolete states from switch statement.

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

updated accordingly

LEAHI-DD-FIRMWARE-LDT-4011-1 28 Jul 2026

updated to not have it update always

LEAHI-TD-FIRMWARE-LDT-4063-1 28 Jul 2026

Updated as suggested by removing the unnecessary else block and reject command. Retested the power-off confirmation and shutdown flow successfully.

LEAHI-DD-FIRMWARE-LDT-4410-3 28 Jul 2026

Add TODO to comment when we do this kind of thing so we don't forget about it.

LEAHI-APPLICATION-LDT-4919-1 28 Jul 2026

BN approves

LEAHI-DD-FIRMWARE-LDT-3735-1 23 Jul 2026

Have these variables been initialized correctly?

LEAHI-DD-FIRMWARE-LDT-4410-3 26 Jul 2026

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

LEAHI-DD-FIRMWARE-LDT-4410-3 26 Jul 2026

This is not the correct order for state machine,

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Removed showUnit and are now basing visibility on length of the unitText.

LEAHI-DD-FIRMWARE-LDT-3978-1 26 Apr 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3978-1 26 Apr 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2004-9 14 Apr 2026

Is this for 64 bit unsigned integer? If not, this is redundant with BIT_BY_POS above.
What does nr stand for?

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

The height of the LabelUnitContainers in Rx are calculated based on the size of the area and number of rows, so there is no hard coded value.

LEAHI-DD-FIRMWARE-LDT-3218-4 15 Apr 2026

fixed

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Updated to use default component size.

LEAHI-TESTSUITES-LDT-1218-1 27 Oct 2025

Addressed points 1 and 2.