•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2936-1 04 Dec 2025

Put space between if and ( for all conditions in this function.

LEAHI-TESTSUITES-LDT-2174-1 07 Dec 2025

Rename the method name to set_Object_Text

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Done

LEAHI-DIALIN-LDT-618-1 08 Dec 2025

Please add function header.

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

do we need override function for high flow rate , low flow rate, conductivity, pressure etc ?

LEAHI-TESTSUITES-LDT-1454-1 09 Dec 2025

Moved this file into utilty.py file

LEAHI-DD-FIRMWARE-LDT-2004-3 09 Dec 2025

Shouldn't EVERY state set ALL valves?

LEAHI-TESTSUITES-LDT-2278-1 05 Dec 2025

Please add the test case to the suite.conf

LEAHI-SW-SCRIPTS-LDT-2727-1 10 Dec 2025

Thanks,
RESOLVED.

LEAHI-APPLICATION-LDT-2727-1 10 Dec 2025

okay will do

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

used for the 1 min user activity timeout to move back to main treatment from heparin.. Its a requirement LEAHI-PRS-666

LEAHI-APPLICATION-LDT-2957-1 10 Dec 2025

updated

LEAHI-DD-FIRMWARE-LDT-2030-2 05 Dec 2025

structure packing missing

LEAHI-TESTSUITES-LDT-2278-1 11 Dec 2025

Renamed the function setObjectText

LEAHI-TESTSUITES-LDT-1454-1 11 Dec 2025

Removed the function and using setObjectText

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Dec 2025

Done. Thank you.

LEAHI-DD-FIRMWARE-LDT-618-3 11 Dec 2025

Added.

LEAHI-TESTSUITES-LDT-2278-1 12 Dec 2025

Removed the wait function

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

added

LEAHI-TD-FIRMWARE-LDT-1886-1 11 Dec 2025

move static function after public function

LEAHI-TD-FIRMWARE-LDT-1886-1 11 Dec 2025

Let all public functions come on top for all files

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Changed

LEAHI-DD-FIRMWARE-LDT-2998-1 05 Jan 2026

Added

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Fixed.

LEAHI-TD-FIRMWARE-LDT-1886-1 02 Dec 2025

Done

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

For testing the patient ID just test 2 different scenarios.
1. Test with a ptient ID (ideally with the full character limit) then enter all parameters then validate

  • Can test the validator only able to enter character that are acceptable..
    2. Test with NO patient ID then enter all parameters then validate.


No need to test 10 different patient IDs just those scenarios listed

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

MODE_TPAR should be deleted.

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Published in the respective modules

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

Publish all other important data like conductivity and pressures

LEAHI-DD-FIRMWARE-LDT-2936-1 26 Nov 2025

Need to co-ordinate with drybicart message id since it is using 0x70

LEAHI-DD-FIRMWARE-LDT-2936-1 03 Dec 2025

arrange static and global function properly , public on top and static on bottom

LEAHI-DD-FIRMWARE-LDT-618-2 04 Dec 2025

Updated

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

I guess my point was, we don't need the "APP_SERVICES" part in the name.

LEAHI-TD-FIRMWARE-LDT-473-1 02 Dec 2025

Missing param line in function header.

LEAHI-TD-FIRMWARE-LDT-473-1 05 Dec 2025

Why was this moved to header file?

LEAHI-TESTSUITES-LDT-2278-1 08 Dec 2025

Renamed the function to match the staging

LEAHI-DD-FIRMWARE-LDT-2004-3 08 Dec 2025

Done.

LEAHI-TD-FIRMWARE-LDT-473-1 16 Dec 2025

Should we request pre-treatment mode here instead? How do we get to pre-treatment mode?

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Missing return statement.

LEAHI-DD-FIRMWARE-LDT-2030-2 11 Dec 2025

Changed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 10 Dec 2025

Please bring public functions on top. check it for all function in this file , except test functions

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

fixed it

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

removed

LEAHI-DD-FIRMWARE-LDT-2185-1 11 Dec 2025

Keep blank line here.

LEAHI-DIALIN-LDT-1886-2 18 Dec 2025

Integer 'i' is 4 bytes. Is that what you mean?

LEAHI-TD-FIRMWARE-LDT-473-1 08 Dec 2025

Message handler functions must have a single parameter (message). The payload of the message will have the param and value in it and this function needs to parse them out of the payload. Also need to check payload length first.
We need a new message ID in MsgDefs.h for Dialin to send us this message and we need to add an entry in the message/handler table in Messaging.c.

LEAHI-TESTSUITES-LDT-1454-1 16 Dec 2025

method name is updated has setObjectText()

LEAHI-DD-FIRMWARE-LDT-2185-1 12 Dec 2025

use the Rinse pump API to get the flow rate