Comment Search

Is this macro still being used? if not, delete it.

Add a space before )

Declare local variables at top of scope.

RESOLVED

minor spell issue : change responceStatus to responseStatus

this line is too long, please break it into two or more lines, if needed.

Should return a BOOL (that is what ModeStandby is expecting).

This is only temporarily showing the FPGA bits of BLD status for debugging purposes.

will finalize it when ocean spray logic is tested

What is this flag for? And why is it only set here and not above where test passed.
Also, we are going to the loaded check state, but we are not requesting a scan first.

removed

Add blank line after declarations.

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

comment out and add TODO to test on new display

RESOLVED.

merged with staging branch and added all the scripts

Space inside parenthesis.

Fix implementation to return a BOOL (TRUE if SW_COMPATIBILITY_REV == ddVersion.compatibilityRev.

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

I agree but it is already in the init function.

This is not required , we should design the state machine properly to handle chamber low level

To be deleted this line?

Use ternary operator to explicitly set to TRUE or FALSE.

This was added by Vinay to force the chamber F filling.

not homed state.