Comment Search

Fixed.

this looks like a genaral method that can be moved to a shared file to be used elsewhere as well

Common methods are moved to utility.py file

This is not how we typically spec details in function headers. Should be inputs and outputs at a minimum (see other function headers for example) and optionally alarms or messages sent or notes.
We can keep these details if you like, but they should be part of the brief above.

I have updated the workflow text

We might need to provide a possibility to override the persistence time on alarm. To be clarified.

the QR code should not be visible. This test is not valid and incorrect because this should fail as we only get QR code once we validate all this checks if that object is there which it is there but not visible. We should be testing the visible property of the QR code section.

This also needs to be moved after the FW td_Treatment_Parameters_Validation to pass

#1. Change Duration -> Verify Heparin Stop Time "active" property is set to off

1. First set Duration, then Bolus Volume, then dispensing rate and then Hep Stop time
2. Change Duration.
3. Verify the "isActive" property of o_PreTreatmentCreate_heparinStopTimeControl_ValueAdjuster is set to False

remove waits and add delay in waitforobject if needed

Please use the mainTreatment screen as the default.
If necessary, could you create a specific enum to clean up the stack (which I do not believe is needed.)

roRRTankFillAvg is an input.

We will address this later on code modularizations.
RESOLVED.

Remove handlePreGenPDefInletWaterState

Does OperationModes.c need to include TxParams.h? TxParams is not a mode.

Pull this line into the grouped property below.

Not able to find in your test.py, but these types of texts will change with the translation, and if the text is used as has been defined here, your test will fail in other languages.
Just be aware and think of a solution to be flexible for later when testing with other languages.

Updated

Removed the wait function

can we make this a more general method and put in a shared file and update throughout.. update to something like

def setObjectText(obj, text):
    obj["text"] = text
    return obj:

remove commented out lines

Should be 2 blank lines above/below test banner.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

Changed this section and rewritten

Removed

Not sure that we need a get function (or even a flag) for rejection. Recommend removing this function.