•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-3208-1 30 Mar 2026

delete line

LEAHI-TESTSUITES-LDT-3208-1 31 Mar 2026

Removed the ine

LEAHI-TESTSUITES-LDT-2839-1 31 Mar 2026

updated as per comment

LEAHI-TESTSUITES-LDT-3120-1 31 Mar 2026

updated as per comment

LEAHI-TESTSUITES-LDT-3188-1 31 Mar 2026

updated as per comment

LEAHI-DD-FIRMWARE-LDT-3603-2 31 Mar 2026

Added

LEAHI-TESTSUITES-LDT-2278-1 31 Mar 2026

Initialize the vital request

vitalsrequest = None

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Why are we commenting this out?

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Remove extra space after "=".

LEAHI-DD-FIRMWARE-LDT-2004-9 01 Apr 2026

Is it time to restore?

LEAHI-DD-FIRMWARE-LDT-1477-1 02 Apr 2026

Done.

LEAHI-DD-FIRMWARE-LDT-3352-1 02 Apr 2026

Done.

LEAHI-DD-FIRMWARE-LDT-3352-1 02 Apr 2026

Done.

LEAHI-DD-FIRMWARE-LDT-3352-1 06 Apr 2026

Not sure these min/max are right here either.

LEAHI-DD-FIRMWARE-LDT-1477-1 02 Apr 2026

Reverse order of comparison.

LEAHI-DD-FIRMWARE-LDT-3352-1 13 Mar 2026

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

LEAHI-DD-FIRMWARE-LDT-1195-2 06 Apr 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3103-3 06 Apr 2026

removed

LEAHI-DD-FIRMWARE-LDT-3103-3 24 Mar 2026

Get this logic into another function and call the function here.

LEAHI-DD-FIRMWARE-LDT-3777-1 08 Apr 2026

Why D43?

LEAHI-DD-FIRMWARE-LDT-2008-1 08 Apr 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3749-2 08 Apr 2026

Add comment that these modes not (yet?) supported.

LEAHI-DD-FIRMWARE-LDT-3749-2 08 Apr 2026

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

LEAHI-DD-FIRMWARE-LDT-3749-2 08 Apr 2026

FALSE?

LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Done

LEAHI-TESTSUITES-LDT-3120-1 30 Mar 2026

Change to "Total Fluid Delivered". This has been changed more recently.

LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Done

LEAHI-DD-FIRMWARE-LDT-2198-1 03 Oct 2025

Done.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done.

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Verified that UF is automatically restarted when user confirms adjusted UF volume.
Updated to close UF adjustment and return to main treatment upon acknowledgment of successful confirm.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Remove pause icon.

LEAHI-APPLICATION-LDT-1440-1 06 Oct 2025

Remove edit close.

TD-LDT-1886-7 29 Sep 2025

Remove 2 of these extra blank lines.

LEAHI-TD-FIRMWARE-LDT-3126-2 17 Mar 2026

Wrong place.

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

I don't understand what you did here. The '*' characters were in the right place before. Do we want to keep the stroke code changes? Do we know where they came from?

LEAHI-TD-FIRMWARE-LDT-1903-9 17 Mar 2026

This code is removed and not required

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

I think this switch should be on requested mode - we haven't changed modes yet.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.

LEAHI-APPLICATION-LDT-3516-1 12 Mar 2026

removed

LEAHI-DD-FIRMWARE-LDT-2004-9 18 Mar 2026

This is to avoid compilation warning

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Result is a BOOL variable, use FALSE.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

if fresh and spent pressure is not met after certain time, we should trigger an alarm and not to stuck in this state forever.

LEAHI-TD-FIRMWARE-LDT-1840-1 13 Mar 2026

Sure

LEAHI-TD-FIRMWARE-LDT-1840-1 13 Mar 2026

Remove extra blank line.

LEAHI-APPLICATION-LDT-3413-1 10 Mar 2026

rename to _currentDataRow

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Added

LEAHI-TD-FIRMWARE-LDT-3126-2 16 Mar 2026

Updated

LEAHI-DIALIN-LDT-696-1 20 Mar 2026

removed duplicate