•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3932-1 06 May 2026

moved to end of line

LEAHI-APPLICATION-LDT-3932-1 06 May 2026

updated name

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

Call your transition function for new state here.

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

remove demo code

LEAHI-APPLICATION-LDT-3932-1 07 May 2026

BN APPROVES

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

remove RO loop demo code

HD-DENBUG-298-1 11 May 2026

RESOLVED in CODE WALKTHROUGH

LEAHI-DD-FIRMWARE-LDT-3963-1 04 May 2026

after one state of BC switching completed. update the next comment as well.

LEAHI-DD-FIRMWARE-LDT-3735-1 23 Jul 2026

This else is not needed because isFlashAddressValid is set to False at the top of the function (Optional to change).

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please remove for the above reasons.

LEAHI-APPLICATION-LDT-4193-1 07 May 2026

check and make same as req/rsp

LEAHI-APPLICATION-LDT-4213-1 05 May 2026

fix indentaitons

LEAHI-DD-FIRMWARE-LDT-4410-3 27 Jul 2026

Also an input I think.

LEAHI-DD-FIRMWARE-LDT-3963-1 08 May 2026

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

updated TODO's as suggested

LEAHI-DIALIN-LDT-4767-1 29 Jul 2026

updated

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

gave space

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Add the comments.

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Do you need to check Band 4 here? less than 80ml or 70 ml, since your comment on band 3 says between 70 to 80ml/min.

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

70ml/min to 80ml/min?

LEAHI-DIALIN-LDT-4890-1 29 Jul 2026

Fixed

LEAHI-DIALIN-LDT-4890-1 29 Jul 2026

Added

LEAHI-DIALIN-LDT-4890-1 29 Jul 2026

Update this list too

LEAHI-DIALIN-LDT-4890-1 29 Jul 2026

Please add a NUM_OF_VALVE_STATES = 4 member too

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

You may need to check other flags such as DryBicartFillRequested( Initial Fill), bicarbChamberFillRequested (Filling Chamber F), instead of 'bicarbChamberPregenFillRequested'. Keep Drain and DepressurizeRequest flag as is. This makes sure at any given point, dryBicartExec calls one of the service only.

LEAHI-TD-FIRMWARE-LDT-4031-1 30 Jul 2026

Updated to store the result in a local BOOL

LEAHI-TD-FIRMWARE-LDT-4029-1 28 Jul 2026

break this line

LEAHI-DD-FIRMWARE-LDT-2004-2 11 Nov 2025

move all structure alignment in to a single block #pragma pack(push,1) and #pragma(pop)

LEAHI-TESTSUITES-LDT-2174-1 11 Nov 2025

Modified the conditions as per your suggestion

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

yes typo and fixed

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Updated

LEAHI-APPLICATION-LDT-4161-1 07 May 2026

updated

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

removre dmeo coed

LEAHI-DD-FIRMWARE-LDT-2936-1 02 Dec 2025

Updated.

LEAHI-TD-FIRMWARE-LDT-2240-1 05 May 2026

change flag to tubeSetLeakChecksStarted

LEAHI-DIALIN-LDT-3505-1 07 May 2026

Please add documentation to the variables.
Format: #: Documentation header from the get function

LEAHI-SW-PLUGINS-SIM-LDT-4919-1 28 Jul 2026

revert

LEAHI-DIALIN-LDT-5246-1 28 Jul 2026

It has been reviewed and approved.

HD-DENBUG-328-1 12 Nov 2025

Please add the comments mentioning the reason/purpose for the checking fluid level timeout alarm?

LEAHI-TESTSUITES-LDT-3670-1 29 Jul 2026

test script is updated in create rx feature

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

removed

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

I think so. the TD needs to know if we are successful in stopping Gen mode for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

why the rowcount is real?

LEAHI-APPLICATION-LDT-2727-1 12 Nov 2025

Do not use the 'const &' on basic types (int, bool, char, ....).
The result is even worse and is not worth it.
But please still keep the alignment.

LEAHI-DD-FIRMWARE-LDT-4500-1 29 Jul 2026

Updated

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

added a function similar to this

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Update description as required.