•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-TESTSUITES-LDT-1802-1 20 Jan 2026

updated as per comment

LEAHI-TESTSUITES-LDT-2971-1 19 Jan 2026

remove if not being used

LEAHI-TESTSUITES-LDT-2971-1 19 Jan 2026

remove if not being used

LEAHI-TESTSUITES-LDT-1802-1 20 Jan 2026

I got error for 3 variations, So I kept 4 variations and error was Detail IndexError: tuple index out of range /home/denali/Public/leaDevTest/leahi-testsuites/suite_leahi/tst_general_alarm_requirements_instruction/test.py:267

LEAHI-DIALIN-LDT-3159-1 20 Jan 2026

Moved it into login request

LEAHI-DIALIN-LDT-3159-1 20 Jan 2026

Renamed

LEAHI-DIALIN-LDT-611-1 19 Jan 2026

This should be renamed to be more concise and allow flexibility as more HW revisions come. What is next gen? All BETAs? BETA 1.9? Beta 2.0? DVT?

LEAHI-DIALIN-LDT-3159-1 19 Jan 2026

The naming of this method is misleading as it sends the message to request defeatured status and it is retrieved in a separate callback. The 'get' implies that the value returned from this method is the defeatured status. The value returned is not the defeatured status but rather a T/F condition on if the FW replied back to dialin successfully.

suggestion: cmd_request_defeatured_status()

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Changed the implementation

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Updated to use isPersistentAlarmTriggered

LEAHI-DIALIN-LDT-2980-1 20 Jan 2026

I didn't added any code for override.
I also can't stop anyone to send in an override command with random numbers.
The allowing of override should be on the FW part, where sending the override with (sensor_id, value, no reset) should return false for those that are not accepted.

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Fixed

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Should we have a comment for this one too?

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

TRUE if low flow alarm is exempt, FALSE if not.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Use #define. Remove high number.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

I don't see this variable used in this function.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Structure should be moved up to definitions section.

BOOTLOADER-LEAH-1415-1 20 Jan 2026

Can we put test code inside of #ifdef TEST_CODE_ENABLED or something so that it is easy to remove later?

BOOTLOADER-LEAH-1415-1 20 Jan 2026

Can you capture intent to resolve my comment in a TODO so we don't lose track of it? (General recommendation for all comments that we are postponing resolution for).

BOOTLOADER-LEAH-1415-1 20 Jan 2026

I think it should be restored even if it's not used anywhere yet.

BOOTLOADER-LEAH-1415-1 20 Jan 2026

TODO

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Add wording to Command Req/Rsp - "Stop/Pause/Resume".
Add increment/decrement msg sequence.

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Updated.

LEAHI-TESTSUITES-LDT-2741-1 19 Jan 2026

before changing the Op mode to service.. Go to standby then press the settings tab on the bottom.

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

What initiates the rinseback state? Firmware or user?

LEAHI-DD-FIRMWARE-LDT-3160-1 27 Jan 2026

resolved

LEAHI-DIALIN-LDT-3160-1 27 Jan 2026

merged

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Yes, Updated

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Updated

LEAHI-TD-FIRMWARE-LDT-1415-1 28 Jan 2026

Updated

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-3139-1 19 Jan 2026

remove

LEAHI-TESTSUITES-LDT-2971-1 20 Jan 2026

Variable name has been updated

LEAHI-APPLICATION-LDT-3106-1 21 Jan 2026

Removed.

LEAHI-TESTSUITES-LDT-2971-1 20 Jan 2026

Removed the object

LEAHI-TESTSUITES-LDT-2971-1 20 Jan 2026

Create treatment button object is using in the test script

LEAHI-DIALIN-LDT-611-1 20 Jan 2026

Renamed, also flagged for future type change.

LEAHI-TESTSUITES-LDT-2971-1 19 Jan 2026

remove first test as it is done in the next test checking setting heparin to OFF.. The first test skips create rx where the second actually sets heparin to OFF and that is the test we want to keep in. Remove lines 143 - 154

LEAHI-DIALIN-LDT-3159-1 19 Jan 2026

This will always return 0 and delay init from completing by up to 0.5s as the user is not logged in at the time of init.

LEAHI-DD-FIRMWARE-LDT-2998-1 21 Jan 2026

Updated

LEAHI-DD-FIRMWARE-LDT-1925-1 20 Jan 2026

Should we rename this function to "isROPumpLowflowAlarmExempt"? The current name makes me think it will set the alarm to be exempt.

BOOTLOADER-LEAH-1415-1 20 Jan 2026

TODO should be all caps for consistency (so we know what to search for).

LEAHI-DIALIN-LDT-3106-1 21 Jan 2026

Is this ID confirmed with FW?

LEAHI-DD-FIRMWARE-LDT-2977-1 23 Jan 2026

I don't see this macro being used anywhere.

LEAHI-DIALIN-LDT-2980-1 20 Jan 2026

We should not allow overrides for newly added internal temperatures

LEAHI-APPLICATION-LDT-2937-1 21 Jan 2026

Updated.

LEAHI-APPLICATION-LDT-3174-1 23 Jan 2026

fixed

LEAHI-APPLICATION-LDT-2937-1 20 Jan 2026

Format message parameters.