•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Update header description for all newly added functions.

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Add comment.

LEAHI-TESTSUITES-LDT-2174-1 06 Nov 2025

please keep the saline bolus ones that are already in staging. Remove the main treatment objects that were added in a different branch/story. Anything in staging that existed before must still exist

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-2662-1 12 Nov 2025

fixed. thanks!

LEAHI-TD-FIRMWARE-LDT-2240-1 07 May 2026

Added

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

check if we need this

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

let stepName = stepNames[stackStepIndex] ?? "".. also fix in pre tx base

LEAHI-APPLICATION-LDT-4161-1 05 May 2026

revert

LEAHI-DIALIN-LDT-3505-1 07 May 2026

please use the generic_override function from the common folder

LEAHI-TESTSUITES-LDT-3670-1 27 Jul 2026

Test script is updated in create rx test script

HD-DENBUG-328-1 12 Nov 2025

Done

LEAHI-TESTSUITES-LDT-1650-1 11 Nov 2025

remove the strings.py file from the project now that we are not going to be using it.

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

Why?

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

Why here?

LEAHI-DD-FIRMWARE-LDT-2004-2 12 Nov 2025

#ifdef

LEAHI-DD-FIRMWARE-LDT-2004-1 12 Nov 2025

space b/w '}' and 'Conductivity'. seen other places too in the file, please check and update.

LEAHI-TD-FIRMWARE-LDT-4063-1 29 Jul 2026

Fix this.

LEAHI-DIALIN-LDT-4890-1 29 Jul 2026

Remove from here too

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

added comment

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-5209-1 30 Jul 2026

Remove empty lines.

LEAHI-DD-FIRMWARE-LDT-2662-1 13 Nov 2025

I think so. the TD needs to know if we are successful in transitioning to PreGen for either the DD or the FP. Otherwise, TD is waiting for something else that'll never happen.

whether that should be a separate message response or ACK is up for discussion.

LEAHI-APPLICATION-LDT-3932-1 05 May 2026

remove

LEAHI-TESTSUITES-LDT-1650-1 18 Nov 2025

Add get_aut_version function and getting UI version using subprocess

LEAHI-TESTSUITES-LDT-1650-1 19 Nov 2025

can you get the path relatively and not hard coded. This path is specific to your VM

LEAHI-TESTSUITES-LDT-1078-1 18 Nov 2025

Add get_aut_version function and getting UI version using subprocess

LEAHI-DIALIN-LDT-4890-1 29 Jul 2026

Updated

LEAHI-TESTSUITES-LDT-1078-1 18 Nov 2025

updated

LEAHI-DD-FIRMWARE-LDT-2662-1 14 Nov 2025

I will resolve this for now, but I don't think ACKs are necessary and I'm pretty sure TD is not looking for a response. TD may be waiting for DD to change mode by looking at DD mode broadcasts.

LEAHI-DD-FIRMWARE-LDT-4410-3 29 Jul 2026

Add blank line after declarations.

LEAHI-DD-FIRMWARE-LDT-2662-1 14 Nov 2025

No I removed it.

LEAHI-DD-FIRMWARE-LDT-2662-1 14 Nov 2025

Done

LEAHI-SW-SCRIPTS-LDT-2727-1 17 Nov 2025

Any specific reason this file is not refactored to the new standard?

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

memcpy is unsafe function. check if there is safer version of memcpy like memcpy_s

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Do not use the magic number.

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

give comments for all parameters

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Always check the return value of snprintf to detect potential errors

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

space required starting and end of switch input parameter

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

There shouldn't be a name if using typedef

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Switch case is better than if else

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

switch case is better than if else. check for all similar implementation.

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

as per coding guide line , it should be tested against the correct value , TRUE or FALSE
for example if ((bufsize ) == 0)

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

Need doxygen comments for all of the parameter

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

align the comments

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

comparing signed and unsigned value. make FLOAT_COUNT as unsigned. Not checking the return value of snprintf if there is any error happened or not.

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

space required at starting and end of the function parameters

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

space required

LEAHI-DD-FIRMWARE-LDT-2004-2 18 Nov 2025

space required. check all other if condition and while statement

LEAHI-TESTSUITES-LDT-1078-1 19 Nov 2025

can you get the path relatively and not hard coded. This path is specific to your VM