•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-3832-1 18 Jul 2020

RESOLVED.

DIALIN-DEN-3832-1 17 Jul 2020

Remove extra line.

DG-DEN-4169-1 31 Jul 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

DONE

DIALIN-DEN-3593-1 20 Jul 2020

Done

DG-DEN-4169-1 31 Jul 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-4169-1 31 Jul 2020

Done

DIALIN-DEN-3964-1 20 Jul 2020

Are you sure they were the same changes? In the other review, the change was to fix the bit masking: http://dvm-linux02:8060/cru/#DIALIN-DEN-3593-1CFR-14160
In this review, the change is to upgrade the valve state handler to write valve states to the "state" key / value pair instead of the valve state variable itself.

DIALIN-DEN-3964-1 20 Jul 2020

Done

DG-DEN-4169-1 31 Jul 2020

This is not squaring through, it is power of 2.

DIALIN-DEN-3964-1 20 Jul 2020

Done

DIALIN-DEN-3593-1 18 Jul 2020

Copyright header missing.

DIALIN-DEN-3964-1 18 Jul 2020

Copyright header missing.

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-4184-1 03 Aug 2020

Aren't the // used for doxygen?

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-4322-1 17 Aug 2020

Fixed.

DG-DEN-4322-1 17 Aug 2020

Done.

DG-DEN-4322-1 17 Aug 2020

Done.

DG-DEN-4322-1 17 Aug 2020

This module has been moved from dgfirmware to fwcommon. Please update to the latest revision to see the removal of this module in dgfirmware.

DG-DEN-4217-1 12 Aug 2020

One liner.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2650-1 04 Jun 2020

It is a static variable in the module

DG-DEN-2379-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 02 Jun 2020

Please make sure to provide a command that can retrieve these parameters from Dialin API for FWV.

DG-DEN-4217-1 12 Aug 2020

Not sure if we want to keep this self test. Not sure it is workable. Added TODO.

DG-DEN-2379-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Figure out where this should go.

HD-DEN-3115-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 26 Jun 2020

Sorry. I think in the merge this happened. I'll add it back

DG-DEN-3922-1 22 Jul 2020

Added doxygen comments

UI-DEN-3253-1 06 Jul 2020

Done

UI-DEN-3253-1 15 Jun 2020

As per our conversation and my demo last Friday about shifting to using svg instead of png, could you please resolve?

DG-DEN-3922-1 22 Jul 2020

Remove extra line.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-4217-1 17 Aug 2020

Done.