•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Please move this file into the Compound folder.

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DIALIN-DEN-3593-1 20 Jul 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-4217-1 20 Aug 2020

Recommend replacing 2 with DG and do the same for other Software Items (HD, etc.).

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-4217-1 20 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 20 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Remove extra space on both lines before the "=".

UI-DEN-3875-1 20 Aug 2020

Sure, but it's a debug code and percent at left makes it not moving much and is readable.

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-4438-1 20 Aug 2020

Why is indentation of } off?

HD-DEN-3115-1 02 Jun 2020

Done

VV-DEN-1434-1 12 Jun 2020

RESOLVED

DG-DEN-4217-1 12 Aug 2020

Where is the Doxygen eof /*@}/?

DG-DEN-2650-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

UI-DEN-3253-1 22 Jun 2020

RESOLVED

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 03 Jun 2020

Done

DG-DEN-4217-1 12 Aug 2020

Remove extra line, also where is the /*@}/ Doxygen comment at eof?

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 02 Jun 2020

sampleCount is a single running average sample counter but it looks like it's being used for multiple sensors. Doesn't look right.

DG-DEN-2379-1 02 Jun 2020

Move this i declaration closer to where it's used (inside the if (CJTemp > 0) body).

DG-DEN-2650-1 04 Jun 2020

Why do we need to remove this line?

DG-DEN-2650-1 04 Jun 2020

No longer a float?

DIALIN-DEN-4438-1 23 Aug 2020

As a general comment, the only folder which has to be modified if required for any feature related to a UI Story has to be only dialin/squish/ folder and none of the other files are related to this Story.
The only one comment related to this story has been addressed.
This comment checked as "Needs resolution" so we all see and agree on this topic after it has been resolved.

UI-DEN-3253-1 26 Jun 2020

Yes, I renamed it to NotificationBarSmall.qml after seeing your comment Peman. I agree NotificationBar2 was not the best name - I was in a bit of a rush to merge the code so I could address the code coverage and unit tests. All the unit tests are now passing but I'm still working on the code coverage

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 15 Aug 2020

init function takes a flexible alarm data type, but check function seems to only take F32.

DG-DEN-3922-1 22 Jul 2020

Done

DIALIN-DEN-4856-1 14 Oct 2020

RESOLVED.

DG-DEN-3922-1 23 Jul 2020

Done

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DIALIN-DEN-2379-1 07 Jul 2020

They had been commented for testing. I uncommented them again.

UI-DEN-3253-1 25 Jun 2020

Remove extra space before : 22 to align with other lines.

DIALIN-DEN-2379-1 07 Jul 2020

Why are these commented out?

DG-DEN-4169-1 31 Jul 2020

We check the inlet water temperature only during Drain, Fill, and Re-circulate modes.

DIALIN-DEN-3832-1 17 Jul 2020

Done

DIALIN-DEN-3832-1 17 Jul 2020

Done

DG-DEN-4169-1 31 Jul 2020

The structure allows grouping of temperature sensor properties in one place rather than spanning across multiple 2D arrays.