•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3253-1 15 Jun 2020

You've already commented about using svg vs. png in the resources/images/alarm.svg, resources/images/bell-off.svg, and resources/images/bell.svg. I don't think you need to find every instance of the svg file to make your point. It goes without saying that the source code will need to be completely changed if we don't use svgs.

DIALIN-DEN-2379-1 07 Jul 2020

Done

UI-DEN-3253-1 15 Jun 2020

Done.

DG-DEN-2650-1 04 Jun 2020

Why were these removed?

DIALIN-DEN-3593-1 07 Jul 2020

Why is there two dialysate_generator.py files in this review project?

DG-DEN-5855-1 10 Dec 2020

Yes, we still use it.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 22 Jun 2020

Peter,
First I didn't notice that #include(s) has been moved into header.
Includes in the header makes compile time unnecessary longer, so if it's not required please put them back in the cpp file.
Since the only change which has been made is the [do,did]FailedTransmit().

DG-DEN-4217-1 12 Aug 2020

Argument not being used in function so I removed it.

UI-DEN-3253-1 22 Jun 2020

RESOLVED

DG-DEN-4322-1 15 Aug 2020

Is param name appropriate?

UI-DEN-3253-1 22 Jun 2020

Please refer to the conversation in comment :
http://dvm-linux02:8060/cru/UI-DEN-3253-1#CFR-13849

UI-DEN-3253-1 12 Jun 2020

Why these two are not defined in the message list spreadsheet?
Where is the definition?

DIALIN-DEN-3593-1 18 Jul 2020

HD stands for Hemodialysis Delivery, not Device.

DIALIN-DEN-3593-1 18 Jul 2020

Copyright header missing.

HD-DEN-15306-3 02 Jun 2023

Oops. DeMorganized and done.

DIALIN-DEN-3964-1 20 Jul 2020

Done

DG-DEN-4217-1 12 Aug 2020

Done

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-4169-1 31 Jul 2020

Fixed, the intention is 5 seconds for both rather than 50 seconds. The SYS team will define the threshold later on.

DG-DEN-4169-1 31 Jul 2020

I generally prefer not using pow() for squaring. Simpler and more efficient to just multiply by itself instead.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4169-1 03 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13598-2 22 Sep 2022

Re-indented with 4 spaces.

DG-DEN-4217-1 20 Aug 2020

Spaces between arithmetic operation signs.

UI-DEN-3875-1 20 Aug 2020

End of lines can't be not to be there.(which currently is there)
QtCreator by defaults adds one if it has been removed.
It's there and Crucible is not showing it.

DG-DEN-3421-1 12 Aug 2020

Will address this issue in the code

DG-DEN-4217-1 20 Aug 2020

Agreed. Will address in another branch - maybe Dara's?

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Dogyxen comments missing for enum.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 20 Aug 2020

Where was this moved to if not deleted?

DG-DEN-4322-1 17 Aug 2020

It can be zero if the incoming water is super clean. It should not be negative through.

UI-DEN-3875-1 21 Aug 2020

RESOLVED.

DG-DEN-4322-1 17 Aug 2020

If shouldn't be negative, should that be checked for and trigger s/w fault? Or is it checked elsewhere in module so can't be negative here?

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

HD-DEN-4211-1 26 Aug 2020

Done

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

DG-DEN-2379-1 03 Jun 2020

Done

UI-DEN-3253-1 22 Jun 2020
UI-DEN-3253-1 15 Jun 2020

As per our conversation and my demo last Friday about shifting to using svg instead of png, could you please resolve?

DG-DEN-4217-1 12 Aug 2020

Add empty line between } and next function call.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-2650-1 04 Jun 2020

This looks like an issue with Dara's merge to this branch. Looks like he corrected it.

HD-DEN-3115-1 04 Jun 2020

Remove //100 commented.

UI-DEN-3253-1 15 Jun 2020

Done.

HD-DEN-3115-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.