•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-2650-1 04 Jun 2020

Why compare to 0 then set to 0.0 (float)?

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Start coefficients right after the first "{" and left adjust/align them.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-4169-1 31 Jul 2020

Align with "a" character

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

UI-DEN-3253-1 15 Jun 2020

Thanks for the demo.
I'm still concerned about performance and some other things and I need to investigate more.
Until then, please use png instead.

UI-DEN-3253-1 22 Jun 2020

These translations need to be in Application and use the enums which has been defined by FW.
Therefore what Peter did is the correct implementation of the translations.
Thanks,

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4169-1 31 Jul 2020

Done

UI-DEN-3253-1 15 Jun 2020

Thanks Peter for talking to Sean to have a kind of definitions in Messages List.
I meant a discussion on how it's going to be done and having some types for parameters at least.
Anyway, although that's not what I meant I'm going to resolve this.
I believe this was not a good task to start with since the FW portion of it was not done.
Maybe better next time.

Thanks,

RESOLVED

UI-DEN-3253-1 15 Jun 2020

Thanks,
RESOLVED.

DIALIN-DEN-4438-1 28 Aug 2020

RESOLVED

DG-DEN-4217-1 17 Aug 2020

Done.

UI-DEN-3253-1 26 Jun 2020

I've updated the unit tests so they are all passing now. I'm just working on increasing the code coverage

UI-DEN-3149-1 22 Jun 2020

I agree.
When time comes this needs to be removed.
I wasn't even sure that it was a solution.
It's in frameInterface@290 which is not in code review since had no change.

UI-DEN-3253-1 26 Jun 2020
UI-DEN-3253-1 22 Jun 2020

This class is the child of the QObject so no need for QObject::tr and tr is enough.

DG-DEN-4322-1 15 Aug 2020

Should this new module be in fwcommon? Looks like it might be useful to HD f/w as well.

DIALIN-DEN-2379-1 07 Jul 2020

Done

DG-DEN-4322-1 15 Aug 2020

Doesn't match function name.

DIALIN-DEN-2379-1 07 Jul 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3964-1 18 Jul 2020

Weird that this code change was also part of the other code review. Please check.

DIALIN-DEN-3964-1 18 Jul 2020

Remove extra line.

DIALIN-DEN-3832-1 17 Jul 2020

print("Drain ...) do not put them on separate lines.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3593-1 18 Jul 2020

Copyright header missing.

DIALIN-DEN-3593-1 18 Jul 2020

Why 2 line spacings in test files when lib/API files have only 2 line spacing?

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

DG-DEN-4217-1 14 Aug 2020

Done

DIALIN-DEN-4211-1 28 Aug 2020

RESOLVED.

DG-DEN-3421-1 10 Aug 2020

Should also set drainPumpDAC in this function.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-4217-1 12 Aug 2020

Argument was not being used in function so I removed it.

DG-DEN-3421-1 12 Aug 2020

Where is the /*@}/ Doxygen comment at eof?

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-4217-1 12 Aug 2020

This self test has been modified to only check the consistency between TPi and Tpo in branch DEN-4169-dg-inlet-water-temperature.

DG-DEN-3421-1 12 Aug 2020

Will fix this throughout code

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 13 Aug 2020

Planned for DEN S26.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 17 Aug 2020

The function has been removed with the use of the module's own enum.

DG-DEN-4322-1 17 Aug 2020

Agree, this function has been removed. For now, the module will use F32 only until we need to account for other type.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 22 Jun 2020