•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3253-1 11 Jun 2020

RESOLVED.

UI-DEN-3253-1 11 Jun 2020

Remove extra line.

UI-DEN-3253-1 11 Jun 2020

Done

UI-DEN-3253-1 11 Jun 2020

RESOLVED.

UI-DEN-3253-1 11 Jun 2020

Remove extra line.

UI-DEN-3253-1 11 Jun 2020

RESOLVED.

UI-DEN-3253-1 11 Jun 2020

Is there any licensing constraint associated with using *.svg files from w3.org? What is the license scheme?

HD-DEN-3115-1 24 Jun 2020

This is HD side so not VDr. I got this abbreviation from HD HDD. My flow path diagram has these two valves as VDi and VDo (for bypassing the dialyzer). HDD has VDio and VDzr. Not sure why the discrepancy, but I think it makes sense to follow HDD for FPGA register names.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 15 Jun 2020

Thanks for the demo.
I'm still concerned about performance and some other things and I need to investigate more.
Until then, please use png instead.

UI-DEN-3253-1 11 Jun 2020

This is a fallthrough - the AdjustBloodDialysateReq will fall through to the AdjustDurationReq case statement.

The extra white-space is intentially removed to indicate it is a fallthrough. Other examples: https://en.cppreference.com/w/cpp/language/switch

UI-DEN-3253-1 11 Jun 2020

Is there any licensing constraint associated with using *.svg files from w3.org? What is the license scheme?

UI-DEN-3253-1 25 Jun 2020

Not a big fan of numeration on variables, functions/methods, etc.

UI-DEN-3149-1 15 Jun 2020

Do you need a semicolon here?

UI-DEN-3149-1 15 Jun 2020

Semicolon

DG-DEN-3922-1 23 Jul 2020

RESOLVED IN CODE WALKTHROUGH

UI-DEN-3149-1 22 Jun 2020

done

DIALIN-DEN-2379-1 07 Jul 2020

Done

DG-DEN-4322-1 15 Aug 2020

Assuming this is F32. Should be 15.0.

DIALIN-DEN-3832-1 17 Jul 2020

Done

HD-DEN-4211-1 28 Aug 2020

Done

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4169-1 31 Jul 2020

I think we want to check all the time in case the temperature dropped to below the range for any reasons

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

DG-DEN-4217-1 19 Aug 2020

Waiting for DG FPGA fix to remove comment permanently as this is a common module.

DIALIN-DEN-3593-1 20 Jul 2020

PEP8 E302: Two blank lines are expected between functions and classes.
PEP8 E303: Two blank lines are expected between functions and classes and one blank line is expected between methods of a class.

DIALIN-DEN-3593-1 18 Jul 2020

Remove commented line.

DG-DEN-4322-1 17 Aug 2020

Done.

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

Done

DG-DEN-13598-2 22 Sep 2022

Done.

DG-DEN-4217-1 20 Aug 2020

This isn't code - it's a commented equation explaining next 2 lines of code. That said, Dara can add spaces for readability on his branch.

HD-DEN-4169-1 31 Jul 2020

Remove extra line.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3875-1 21 Aug 2020

Ok, RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Done

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 10 Aug 2020

Why is this commented out? It will prevent SW2 from turning on drain pump.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 13 Aug 2020

Shouldn't this be ms to min?

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-4322-1 21 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-4322-1 21 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.