•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-3115-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 31 May 2020

Create constant if this is here to stay.

UI-DEN-3149-1 11 Jun 2020

canBusFaultCountData?

HD-DEN-3115-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 11 Jun 2020

spelling of "don't" for subject we and ",": "... , which we currently don't have."

UI-DEN-3149-1 11 Jun 2020

What is this comment for?

UI-DEN-3149-1 11 Jun 2020

Why space?

UI-DEN-3149-1 11 Jun 2020

spelling: duration

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2650-1 11 Jun 2020

Clean up

VV-DEN-1434-1 10 Jun 2020

Looks good overall! I've added a few comments. Also to conform to PEP8, all folders should be lowercase_with_underscores. The Dialin_API folder should be renamed to dialin_scripts since the Dialin API is a located in a separate repository

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

VV-DEN-1434-1 10 Jun 2020

.bat a script file in DOS, OS/2 and Microsoft Windows. I think the filename should be .sh since this script will be run on linux.

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

VV-DEN-1434-1 10 Jun 2020

Any pyc file should not be committed to the repository

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

VV-DEN-1434-1 10 Jun 2020

Add *.pyc

UI-DEN-3253-1 11 Jun 2020

Add empty line.

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 11 Jun 2020

Remove empty line.

DG-DEN-2650-1 05 Jun 2020

Done

DG-DEN-2650-1 11 Jun 2020

What is our plan to adjust these constants across machines?

DG-DEN-2650-1 05 Jun 2020

Done

DG-DEN-2650-1 05 Jun 2020

Value in mV

UI-DEN-3253-1 22 Jun 2020

same :
Please change pressed to clicked as we discussed.

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2650-1 05 Jun 2020

Change it to TODO, instead.

DG-DEN-2650-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 22 Jun 2020

Much better thanks.
RESOLVED

UI-DEN-3253-1 11 Jun 2020

Add empty line.

UI-DEN-3149-1 23 Jun 2020

Remove extra lines.

UI-DEN-3253-1 25 Jun 2020

Same comment.

VV-DEN-1434-1 10 Jun 2020

Needs a script header

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 25 Jun 2020

Why space before .?

DIALIN-DEN-3922-1 22 Jul 2020

RESOLVED.

DG-DEN-3922-1 22 Jul 2020

Done

DG-DEN-2650-1 11 Jun 2020

I imagine we would settle on a nominal (theoretical) gain/offset here and then apply calibration gain/offset from NV memory afterward to get a final conversion.

DG-DEN-2650-1 11 Jun 2020

I do remove build flags that I don't need anymore every so often. If we're done with CAN testing I can remove that one. I'm still using the rest of these from time to time.

UI-DEN-3149-1 11 Jun 2020

Talked with Behrouz. RESOLVED.

UI-DEN-3149-1 10 Jun 2020

Is it not possible to remove .user file from git tracking?

VV-DEN-1434-1 11 Jun 2020

Fixed

VV-DEN-1434-1 11 Jun 2020

Fixed

VV-DEN-1434-1 11 Jun 2020

Fixed

VV-DEN-1434-1 11 Jun 2020

Fixed, rename directories to lowercase.

UI-DEN-3253-1 11 Jun 2020

Is there any licensing constraint associated with using *.svg files from w3.org? What is the license scheme?

UI-DEN-3253-1 11 Jun 2020

The Bell icons are obtained from here: https://feathericons.com/

It is an open source icon and uses the MIT license

UI-DEN-3253-1 11 Jun 2020

The alarm.svg is provided to us by Karten.

The xmlns link is just pulling a resource to build the icon from w3.org

UI-DEN-3253-1 11 Jun 2020

This bell-off.svg icon is obtained from: https://feathericons.com/

It is an open source icon and uses the MIT license

UI-DEN-3253-1 11 Jun 2020

Add empty line between each case.