The temperature sensor has been refactored in branch DEN-4169-dg-inlet-water-temperature that has been reviewed. The code here will be obsoleted once we merge the branch in.
Yes. I am calculating the heat disinfection time since the beginning of the mode in ms and then divide it to 60000 to convert it to minutes for publication.
Until Karten provides us png's that match the alert color level that is dictated by the requirements, I have to use svg's to dynamically draw the appropriate color and background. If we get a request to change the color, using a png will require that they send us new png's. Using svg's saves time so we don't have to go back and forth with them to change the color scheme of the png's.
All the unit tests are passing with this menu right now. Code coverage is almost 100%. Deleting it will break many squish qt tests and may also affect the code coverage. The HW team can access the diagnostics screen the same as before on the diagnostics page, which is listed second on the settings page, very clearly, and quickly accessible.
What is the use case of disabling the alarms? It makes application kind of mute like some one who can't talk or communicate. Seems like a dangerous switch. I prefer not to be kept as a switch, if needs for debugging better to use #ifdef instead.
This is HD side so not VDr. I got this abbreviation from HD HDD. My flow path diagram has these two valves as VDi and VDo (for bypassing the dialyzer). HDD has VDio and VDzr. Not sure why the discrepancy, but I think it makes sense to follow HDD for FPGA register names.
Peter, Thanks for the nice menu here. But with the requests we received recently for HW support seems like they need those screens to be the way it is for quick access to debug information. We may need to revert that back to the previous navigation mode. We can have a conversation how to do that. Thanks,
Thanks Peter, I disagree with the last sentence. We should not simulate the behavior to meet the requirement. But I agree that we need to have the simulation to see the code is not misbehaving.
