•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-3115-1 02 Jun 2020

Same here.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 02 Jun 2020

Insert blank line between each comment/void

DG-DEN-2650-1 04 Jun 2020

Where is isROPumpOn declared?

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Why this check is no longer required?

DIALIN-DEN-3593-1 20 Jul 2020

Done

UI-DEN-3253-1 26 Jun 2020

These are my code Peman,
And has been merged from master, somehow. (Original code is not in this screen and are in SettingsHome.qml)
As usual it helps to immediately identify that toFixed() function has not been forgotten and been used to set decimal point by 2 digits.

DG-DEN-3922-1 22 Jul 2020

Removed after adding appropriate build flag to vectorcast.

DG-DEN-3922-1 22 Jul 2020

Remove extra lines.

UI-DEN-3253-1 06 Jul 2020

Please see my above and linked to by Behrouz. To avoid future merge conflicts, I think it'd be best to ensure the styling issues are fixed only on Behrouz's branch instead of here too. If you agree, I think this and the above comment can be resolved.

UI-DEN-3253-1 12 Jun 2020

Why these two are not defined in the message list spreadsheet?
Where is the definition?
Please collaborate with FW Team to have correct length here even if it has not been defined it needs a definition to have a placeholder.

UI-DEN-3253-1 12 Jun 2020

There was no Fall through in the original code.
Please, do not remove codes even if it's the same code.
Even if we are going to (which we are not) have fall through there should be Q_FALLTHROUGH(); in the code as has been stated in the C++ coding standard.

DG-DEN-12224-7 23 May 2022

Done.

DG-DEN-4217-1 12 Aug 2020

One liner

DG-DEN-4217-1 12 Aug 2020

Add empty line after }.

UI-DEN-3253-1 26 Jun 2020

Good catch

DG-DEN-3421-1 12 Aug 2020

I would call Reservoir/RSVR/R all the same as R1 and R2 everywhere.

DG-DEN-2650-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 12 Jun 2020

we are not handling timeouts and timers in application.
It makes application and HD out of sync.
HD will send the times if required each second.
That's how it has been discussed and designed.
There should be a message later which has the timeout as a data and UI only updates itself by that value.
If it's not for animation, please remove it.

UI-DEN-3253-1 12 Jun 2020

We are no using svg.
Please use only png.

UI-DEN-3253-1 12 Jun 2020

Please update the Copyright regarding the filename.
Please change the file name (back) to NotificationDialog.qml the first name you had was better.

UI-DEN-3253-1 12 Jun 2020

Why the interval is 1 millisecond.
It's too fast for any purpose on the UI.

DG-DEN-3421-1 12 Aug 2020

Align Doxygen comments.

DIALIN-DEN-2379-1 07 Jul 2020

Done

UI-DEN-3253-1 12 Jun 2020

Please do not use QGraphcalEffects our device display resolution and color depth is not supporting it and most of the time it makes application ugly.

HD-DEN-3115-1 23 Jun 2020

VDr (instead of VDzr)?

DG-DEN-4169-1 31 Jul 2020

The water temperature will not cause an issue if we do not produce dialysate through, because the water will drain out later.

DG-DEN-4169-1 31 Jul 2020

Why was the 2D array changed to a structure for the temperature sensors constants?

UI-DEN-3253-1 06 Jul 2020

Hi Peman I believe I have finished the action item related to your comment - it is now named NotificationBarSmall

DG-DEN-4169-1 03 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 07 Jul 2020

RESOLVED.

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DG-DEN-5846-1 30 Nov 2020

You mean rename it?

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DIALIN-DEN-2379-1 09 Jul 2020

They are still commented out.

DIALIN-DEN-3832-1 17 Jul 2020

sub-modes

DIALIN-DEN-3593-1 20 Jul 2020

Done

DG-DEN-4217-1 12 Aug 2020

Remove unused variable i.

DG-DEN-3421-1 12 Aug 2020

Add space between , and i

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Done

DIALIN-DEN-3964-1 20 Jul 2020

PEP8 requires that there are two spaces between functions outside of a class.
If I delete a space, it violates PEP8: E305

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Done