•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

DG-DEN-3421-1 12 Aug 2020

Will fix this in the code

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 13 Aug 2020

I put it a little bit above bottom and it looks like Dara added at bottom. There should only be one of these. Dara, keep mine and remove this one at very bottom.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Where is the Doxygen /*@}/ ending of file?

DG-DEN-3421-1 12 Aug 2020

Remove extra space on all three lines before the "=".

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 02 Jun 2020

This is test code. I've added a comment to this line for TODO to define this volume in pre-treatment mode when developed.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

UI-DEN-3253-1 12 Jun 2020

If this case does nothing why it is here?
This is the QVariantList version which we are going to use it only for debugging later and I thing you didn't even used it.
Please remove.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-2379-1 07 Jul 2020

Done

DG-DEN-2379-1 02 Jun 2020

For verification, the coefficients of the conversion equations can be retrieved from the SDD.

DG-DEN-2379-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DG-DEN-2379-1 05 Jun 2020

They are all in the arrays at the bottom of the private variables

HD-DEN-3115-1 24 Jun 2020

Slower ramp up gives time to detect occlusion before things get too fast. Also, for blood, we will want to ramp up slowly for patient comfort I imagine.
For ramp down, I think we want to be more aggressive in stopping pumps - may be due to alarm - want to get to controlled stop ASAP.

UI-DEN-3253-1 12 Jun 2020

I see what you mean, But the png they will give us has to have transparent background so the background of the parent will be the background of the image and the bell/speaker icon will have only white border.

DG-DEN-3922-1 23 Jul 2020

We either finish all comments everywhere with dots or we don't, but we need to be consistent.

DG-DEN-2650-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

What about R2? We are not handling it anymore?

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DIALIN-DEN-2379-1 07 Jul 2020

Will DG have an RTC class as well?

UI-DEN-3253-1 26 Jun 2020

Hummmm,
Same as which comment?
Sorry seems like Jira doesn't show comments in order I can't follow the comments in order.

But I have another question why we have "Notification2" ?
We suppose to have one and only one NotificationBar.
It will break all the other unit tests...
Could be more clear on this?

UI-DEN-3253-1 22 Jun 2020

Sequence is used in the header file. It is defined in the Can namespace. guicontroller.h imports messageglobals.h.
To clear it up, so there is no confusion, I've just moved the guicontroller.h import to .cpp and directly importing messageglobals.h in the header.

UI-DEN-3253-1 22 Jun 2020

RESOLVED

UI-DEN-3253-1 12 Jun 2020

We are not using svg.
Please use only png.

DG-DEN-3922-1 24 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 26 Jun 2020

Why?

HD-DEN-3115-1 23 Jun 2020

VDr (instead of VDzr)?

DG-DEN-4217-1 12 Aug 2020

Argument no longer needed?

UI-DEN-3253-1 06 Jul 2020

Please see my above and linked to by Behrouz. To avoid future merge conflicts, I think it'd be best to ensure the styling issues are fixed only on Behrouz's branch instead of here too. If you agree, I think this and the above comment can be resolved.

DG-DEN-3421-1 12 Aug 2020

Where is the TODO?

UI-DEN-3253-1 06 Jul 2020

Done

DG-DEN-5846-1 30 Nov 2020

Very good point. Done.

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-5855-1 10 Dec 2020

Done

DG-DEN-4217-1 12 Aug 2020

Remove commented line (or add a TODO with clear explanation why this is commented out).

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Remove extra space on all three lines before the "=".

DG-DEN-4322-1 15 Aug 2020

Add DG s/w fault identifier so when logged we can determine which of the MANY s/w faults actually occurred.

DG-DEN-3421-1 12 Aug 2020

Done