I put it a little bit above bottom and it looks like Dara added at bottom. There should only be one of these. Dara, keep mine and remove this one at very bottom.
If this case does nothing why it is here? This is the QVariantList version which we are going to use it only for debugging later and I thing you didn't even used it. Please remove.
Slower ramp up gives time to detect occlusion before things get too fast. Also, for blood, we will want to ramp up slowly for patient comfort I imagine. For ramp down, I think we want to be more aggressive in stopping pumps - may be due to alarm - want to get to controlled stop ASAP.
I see what you mean, But the png they will give us has to have transparent background so the background of the parent will be the background of the image and the bell/speaker icon will have only white border.
Hummmm, Same as which comment? Sorry seems like Jira doesn't show comments in order I can't follow the comments in order.
But I have another question why we have "Notification2" ? We suppose to have one and only one NotificationBar. It will break all the other unit tests... Could be more clear on this?
Sequence is used in the header file. It is defined in the Can namespace. guicontroller.h imports messageglobals.h. To clear it up, so there is no confusion, I've just moved the guicontroller.h import to .cpp and directly importing messageglobals.h in the header.
Please see my above and linked to by Behrouz. To avoid future merge conflicts, I think it'd be best to ensure the styling issues are fixed only on Behrouz's branch instead of here too. If you agree, I think this and the above comment can be resolved.