•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-1 12 Aug 2020

Will fix this throughout code

DG-DEN-3421-1 12 Aug 2020

Where is the Doxygen /*@}/ ending of file?

DG-DEN-4217-1 12 Aug 2020

Missing the Doxygen /*@}/ at eof.

HD-DEN-3115-1 02 Jun 2020

Done

UI-DEN-3149-1 12 Jun 2020

Spelling: TemperatureSensors

UI-DEN-3149-1 23 Jun 2020

Same as "Resume Ultrafiltration".

DG-DEN-2650-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 22 Jun 2020

done

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-2650-1 04 Jun 2020

This is trying to avoid divide by zero. Easier to compare the average sum of readings (integer) to zero than the average (float).

DG-DEN-2379-1 03 Jun 2020

Where did all these temperature coefficients go?

HD-DEN-3115-1 02 Jun 2020

Same here.

UI-DEN-3253-1 22 Jun 2020

RESOLVED

HD-DEN-3115-1 05 Jun 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 02 Jun 2020

Same here.

DG-DEN-2650-1 04 Jun 2020

What does t = -1.0 mean? Is that a default temperature?

DG-DEN-3421-1 20 Aug 2020

50 what? A bit more verbose?

DIALIN-DEN-3922-1 22 Jul 2020

RESOLVED.

UI-DEN-3253-1 22 Jun 2020

We had a conversation to look into the SVG images for :

  • default color and change it to white (it's black) so we don't need QGraphcalEffects and ColorOverlay to manipulate SVG images properties.
  • also see if it is a reference or the actual svg so the code can be build without internet the content of the file is so tiny regarding the image itself.
UI-DEN-3253-1 06 Jul 2020

Done.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

UI-DEN-3253-1 07 Jul 2020

RESOLVED.

UI-DEN-3253-1 25 Jun 2020

Same comment here.

DG-DEN-4217-1 12 Aug 2020

Why was this deleted to be re-added? I remember I had this in.

DIALIN-DEN-3593-1 16 Jul 2020

RESOLVED.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-3922-1 22 Jul 2020

Why there is no break at the end of the case?

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DIALIN-DEN-3593-1 18 Jul 2020

Remove extra line.

DG-DEN-4217-1 12 Aug 2020

Remove commented line (or add a TODO with clear explanation why this is commented out).

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-3922-1 23 Jul 2020

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 18 Jul 2020

Remove extra lines.

DIALIN-DEN-3593-1 18 Jul 2020

Copyright header missing.

DIALIN-DEN-3964-1 18 Jul 2020

Remove extra line.

DIALIN-DEN-3964-1 18 Jul 2020

Copyright header missing.

DG-DEN-3922-1 22 Jul 2020

Why the private data and private definitions do not have the doxygen comments?

DG-DEN-4217-1 12 Aug 2020

Argument no longer needed?

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 15 Aug 2020

This approach assumes init function will not be called more than once for same alarm ID. Risky. Should at least make it clear in function or module header that this is not allowed.
I used an enum in TimeWindowedCount. That approach maybe not as elegant, but avoids this risk and also avoids potential of running out of persistent alarms.

DG-DEN-4169-1 31 Jul 2020

The structure allows grouping of temperature sensor properties in one place rather than spanning across multiple 2D arrays.

DG-DEN-4322-1 15 Aug 2020

Not sure we need to override this. Can already override numerator and denominator.

HD-DEN-4169-1 03 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 10 Dec 2020

Done

DG-DEN-3421-1 12 Aug 2020

Remove extra space on both lines before the "=".

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.