•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 12 Jun 2020

putting ; at the end of the line is not necessary in QML.
Please, put it only if required and if not necessary don't add or remove it.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2650-1 04 Jun 2020

If the cold junction temperature is not positive, I cannot use the coefficients to calculate the temperature and I have to use other coefficients which I did not implement since we don't go to negative temperature. So if the cold junction is negative, I set an alarm and set the temperature to -1.0 and not 0 to show that cold junction became negative.

DG-DEN-2650-1 04 Jun 2020

Never was a float.

DG-DEN-2379-1 02 Jun 2020

Since runningSum is an integer, consider changing sample count to a power-of-two value (e.g. 16 or 32) so you can replace this division with a right bit shift (much faster). Would mean your average would be low until your running average buffer is full of samples though.

UI-DEN-3253-1 22 Jun 2020

RESOLVED

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-3115-1 06 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 26 Jun 2020

Thank god.
It was killing me.
I couldn't help to not to say that

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 06 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DIALIN-DEN-2379-1 07 Jul 2020

Eventually yes. I have a TODO note to add RTC to DG as well.

DG-DEN-4217-1 12 Aug 2020

One liner

DIALIN-DEN-3593-1 20 Jul 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3593-1 20 Jul 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

Done

UI-DEN-3253-1 26 Jun 2020

The use case is for us to be able to run the code coverage tests without the UI raising alarms when the HD is not connected. This is so the other squishqt tests will be able to run normally. Otherwise, squishqt can't find the qml components when the HD communication timeout alarm shows and some of the other squishqt tests will fail.

UI-DEN-3253-1 26 Jun 2020

Is there any particular reason why some of the messages have space at the end and some others don't?

UI-DEN-3253-1 26 Jun 2020

Could you please explain what is this component and why we have it.
We should have only one NotificationBar.

But as it seems it is only being used for notifications on each sections of MainTreatment screen.
If that is the case, It is a good idea but then we need to have a kind of parent and child components structure in which the parent is the simple one and the children have the extra features. like what we currently have in Dialogs.
Please let me review what would be the good implementation.

Peter, if you want to change these kind of things please collaborate, negotiate and let's review the rational behind the existence of a component and then change it together.
Thanks,

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

I think Quang moved this check to somewhere else where only checked in treatment modes in one of his branches. Added TODO.

DIALIN-DEN-3593-1 20 Jul 2020

Comment says DONE but I still cannot see the copyright header.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3964-1 20 Jul 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DIALIN-DEN-3964-1 20 Jul 2020

Done

DIALIN-DEN-3964-1 20 Jul 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Done.

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 15 Aug 2020

Doesn't match function name.

DG-DEN-4322-1 19 Aug 2020

Why the blank lines?

DG-DEN-3421-1 12 Aug 2020

Will fix this throughout code

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Where is the Doxygen /*@}/ ending of file?

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 17 Aug 2020

Fixed.

UI-DEN-3875-1 20 Aug 2020

done

DG-DEN-4322-1 17 Aug 2020

Moved to fwcommon.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Where is the Doxygen eof /*@}/?

UI-DEN-3149-1 12 Jun 2020

Thanks again for catching that,
Corrected.

HD-DEN-3115-1 02 Jun 2020

Done