•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-3593-1 20 Jul 2020

Done

DG-DEN-4217-1 12 Aug 2020

FPGA ALL CAPS

DG-DEN-3421-1 12 Aug 2020

OK but don't you want to also add an else with an throw error as catch all as last condition check?

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Only 1 space between ) and // comment

DIALIN-DEN-3832-1 18 Jul 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3832-1 18 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 18 Jul 2020

Remove extra line(s).

DIALIN-DEN-3593-1 18 Jul 2020

Remove extra line.

DG-DEN-4217-1 12 Aug 2020

Start coefficients right after the first "{".

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 18 Jul 2020

HD stands for Hemodialysis Delivery, not Device.

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 18 Jul 2020

HD stands for Hemodialysis Delivery, not Device.

DIALIN-DEN-3593-1 18 Jul 2020

Remove extra line.

DG-DEN-4217-1 12 Aug 2020

Space after // in comments

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

DIALIN-DEN-3593-1 18 Jul 2020

Diality Inc (not Inc.)

DIALIN-DEN-3964-1 18 Jul 2020

Remove extra lines.

DG-DEN-4217-1 17 Aug 2020

No space between function name and "("

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Could you please explain more?

DG-DEN-4322-1 17 Aug 2020

Done.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-3875-1 20 Aug 2020

done

DG-DEN-4217-1 12 Aug 2020

Where is the Doxygen eof /*@}/?

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 11 Jun 2020

this not a code comment.
It's like a section separator to me.

UI-DEN-3149-1 12 Jun 2020

Put informtion

DG-DEN-3922-1 21 Jul 2020

Done

UI-DEN-3149-1 12 Jun 2020

Comment removed on appropriate place and the file itself has been removed.

VV-DEN-1434-1 12 Jun 2020

RESOLVED

VV-DEN-1434-1 12 Jun 2020

Thanks Sarina! RESOLVED

HD-DEN-9480-1 10 Nov 2021

Done.

VV-DEN-1434-1 12 Jun 2020

RESOLVED

UI-DEN-3149-1 23 Jun 2020

1. Response (instead of responce, also fix spell checker);
2. accepted (instead of accpted).

VV-DEN-1434-1 12 Jun 2020

RESOLVED

UI-DEN-3149-1 23 Jun 2020

msg complete (instead of msg compelete)

UI-DEN-3253-1 14 Jun 2020

Please rename this signal to "clicked" to clarify the definition and usage.
It's confusing since, "Pressed" and "Released" all together are "Clicked" event.

HD-DEN-3115-1 06 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Not sure how/where it got dropped if you had it before.

DG-DEN-3922-1 21 Jul 2020

What about DG_SOFTWARE_FAULT? Where is that being handled?

DIALIN-DEN-2379-1 07 Jul 2020

Done