•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-3964-1 20 Jul 2020

Done

DG-DEN-3922-1 21 Jul 2020

Remove extra line.

DIALIN-DEN-3964-1 20 Jul 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Done

UI-DEN-4438-1 25 Aug 2020

done

DG-DEN-4322-1 26 Aug 2020

Fixed.

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

HD-DEN-4211-1 26 Aug 2020

Done.

DG-DEN-3421-1 12 Aug 2020

All modules will have doxygen hooks eventually

HD-DEN-4211-1 26 Aug 2020

Done

DG-DEN-3421-1 13 Aug 2020

Remove extra space before the first void.

DG-DEN-3421-1 13 Aug 2020

DECISION: This will be done in DEN S26.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 17 Aug 2020

Fixed.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 23 Jun 2020

RESOLVED

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

VV-DEN-1434-1 11 Jun 2020

Fixed. Removed *.pyc from repo.

VV-DEN-1434-1 12 Jun 2020

RESOLVED.

DG-DEN-3922-1 21 Jul 2020

Done

UI-DEN-3149-1 12 Jun 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-3922-1 22 Jul 2020

Update C Coding Standard to add max. width.

DG-DEN-3421-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 12 Jun 2020

These are placeholders until Sean has time to put them in the message list spreadsheet

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed?

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 06 Jul 2020

Still not clear.
Ok for now.

RESOLVED

DIALIN-DEN-2379-1 01 Jul 2020

Our python coding standard requires lower_case_with_underscores for variable names and function names.

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

HD-DEN-3115-1 19 Jun 2020

Why were the #pragmas removed?

DG-DEN-3922-1 21 Jul 2020

Align comment.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 19 Jun 2020

What changed in the memory mapping?

UI-DEN-3253-1 12 Jun 2020

We are not using svg.
Please use only png.

UI-DEN-3253-1 12 Jun 2020

We are no using svg.
Please use only png.

DIALIN-DEN-3593-1 20 Jul 2020

Done

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DIALIN-DEN-3593-1 20 Jul 2020

RESOLVED.

UI-DEN-3149-1 14 Jun 2020

The benefit of this defines are to guard the code.
It has been defined to make developers to only use the code the way it has been defined.
Since the QML can't use template classes they have been defined with the #define.
Please only use the defines in correct way to protect the code.

UI-DEN-3253-1 12 Jun 2020

Putting ; at the end of the line is not necessary in QML.
Please put it only if required and if not necessary don't add or remove it.

DG-DEN-3421-1 12 Aug 2020

Yes, sure. I added the stop command in the internal heat disinfect state.

DG-DEN-4217-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3593-1 20 Jul 2020

This file is symbolically linked to dialin/version.py - the copyright header is in that file

DIALIN-DEN-3421-1 10 Dec 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done. Put it in common.h in fwcommon.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.