•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-4438-1 28 Aug 2020

RESOLVED

UI-DEN-3149-1 12 Jun 2020

RESOLVED.

UI-DEN-3253-1 01 Jul 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DG-DEN-3922-1 21 Jul 2020

Let's call them cpi and cpo? This will match with the DG HDD.

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DD-LDT-1873-4 02 Sep 2025

Done.

UI-DEN-3149-1 14 Jun 2020

Thanks for catching again.
The spellchecker has been stopped working and I can't make it run again.
Corrected.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 17 Jun 2020

RESOLVED.

HD-DEN-3115-1 19 Jun 2020

HALCoGen did this when I changed from FIQ to IRQ.

DG-DEN-4217-1 12 Aug 2020

We should provide somewhere a description of what critical data is, at least few examples given at this level.

HD-DEN-3115-1 19 Jun 2020

HALCoGen removed these when I changed from FIQ to IRQ.

UI-DEN-3253-1 06 Jul 2020

The name is too general please change the name that reflects the test.
If it's not one test please separate them.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5282-1 30 Oct 2020

These can be found in common
See the RequestRejectReasons enum in common/msg_defs.py

DG-DEN-2650-1 19 Jun 2020

The 4 reservoir valves are controlled by the HD when it's connected and on. In Standby mode, the HD is connected and on.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3922-1 21 Jul 2020

Missing conductivity param.
Should we even have a conductivity parameter for this function? Why should caller have to provide this to the module that owns it?

DIALIN-DEN-3922-1 21 Jul 2020

What is a *.swp file type and why was it added to the gitignore list?

DG-DEN-2650-1 19 Jun 2020

I have the typedef immediately following the associated enum to show they are coupled. Previously I had the typedef included in the enum declaration but Qt didn't like that.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 02 Jun 2023

Done.

DG-DEN-4217-1 11 Aug 2020

At the moment, I only have one GPIO (that I borrow from drain pump enable) to share for all tasks so I can't leave them all un-commented. Ideally, we find spare GPIO pin for each task. For now, the #ifdef is just determining whether borrowed pin is for drain pump or task timing.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13598-2 22 Sep 2022

Done.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 13 Aug 2020

Done.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

DG-DEN-4322-1 15 Aug 2020

Should be a break; after this to exit loop (no point in continuing the loop after we find the alarm).

DG-DEN-4322-1 17 Aug 2020

Fixed.

DG-DEN-4322-1 17 Aug 2020

Agree. Fixed.

DG-DEN-4217-1 20 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 15 Aug 2020

Do we need to broadcast the ratio? CPi and CPo are already broadcast so ratio can be had with provided information.

DG-DEN-4322-1 17 Aug 2020

Fixed.

DG-DEN-4217-1 19 Aug 2020

Commented -1.0 on purpose?

DG-DEN-4322-1 17 Aug 2020

Fixed.

DG-DEN-13598-2 22 Sep 2022

Removed.

UI-DEN-3875-1 20 Aug 2020

Sure, but it's a debug code and percent at left makes it not moving much and is readable.

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

Change sentence to: It is preferred to keep it as is so that the initialization is independent of data.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-4322-1 20 Aug 2020

Why removed?

DIALIN-DEN-4322-1 21 Aug 2020

Done.