•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3875-1 14 Aug 2020

The percent sign should go after the number, not before it

DG-DEN-4322-1 20 Aug 2020

Why file deleted?

UI-DEN-4438-1 25 Aug 2020

Remove extra line.

UI-DEN-4438-1 20 Aug 2020

Remove extra line at EOF.

DG-DEN-2379-1 20 May 2020

Done

UI-DEN-3253-1 23 Jun 2020

Done

VV-DEN-1434-1 11 Jun 2020

Fixed. File is moved to a branch.

HD-DEN-3115-1 27 May 2020

Done.

UI-DEN-3253-1 11 Jun 2020

Where was this list of alarms obtained from and how do we know it is matching the supported ones in the DG/HD Firmware?

DG-DEN-2379-1 20 May 2020

Add module comment for doxygen.

HD-DEN-3115-1 27 May 2020

Remove extra line.

HD-DEN-3115-1 27 May 2020

Is this supposed to change? Is this per device? Is this general parameter?

UI-DEN-3149-1 12 Jun 2020

This is not part of our coding standard, please remove.

DG-DEN-2379-1 27 May 2020

Done

UI-DEN-3149-1 19 Jun 2020

Remove extra line.

DG-DEN-2379-1 27 May 2020

Done

UI-DEN-3149-1 12 Jun 2020

RESOLVED.

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

UI-DEN-3253-1 01 Jul 2020

Done

HD-DEN-4308-3 05 Oct 2020

Removed all the residual \n in the module.

UI-DEN-3875-1 20 Aug 2020

done

DG-DEN-2379-1 27 May 2020

This part of code was not available in this branch. I commented it, it will be added in the DG firmware infrastructure branch.

DG-DEN-3421-1 12 Aug 2020

I added a TODO to add a software fault in default mode. I have not added the faults yet.

DG-DEN-2379-1 27 May 2020

Yes, I created a function for this state for two reasons: 1. To be consistent with the rest of the states 2. I think we should create a delay for FPGA to read the data although I added the delay in the exec state machine. This function will be mostly used as a place holder.

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Need function headers.

UI-DEN-3149-1 12 Jun 2020

Spelling: TemperatureSensors

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 17 Jun 2020

Dispositioned to http://dvm-linux02:8080/browse/DEN-3742

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3421-1 10 Dec 2020

Done

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3922-1 21 Jul 2020

The updated FPGA added fpgaRevLab and fpgaRevMajor, which pushed the address offset up by 2.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

A comment explaining what you're doing here (sign extending a 14-bit value) would be helpful.

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 19 Jun 2020

I re-sized stacks in HALCoGen and it made these changes.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 12 Jun 2020

These objects don't need to be children of the the MouseArea.
Please only put MouseArea at the end of the page and put the other object before that.

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 06 Jul 2020

Typo :
erro

UI-DEN-3253-1 06 Jul 2020

Typo ?
inconsisten

DIALIN-DEN-3922-1 21 Jul 2020

It is a "swap" file in Linux, containing the unsaved changes. It is a temporary file and sometimes if we do not ignore, we might accidentally add it to the commit.

DIALIN-DEN-3922-1 21 Jul 2020

Done

DG-DEN-3922-1 21 Jul 2020

Give each param a separate line and describe it.