•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-4217-1 12 Aug 2020

Done

DIALIN-DEN-4640-1 05 Oct 2020

Where were these HD Alarms moved to?

DG-DEN-3421-1 13 Aug 2020

Planned for DEN S26.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4211-1 09 Sep 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

fillWeightLoadCell initialized to A1 at top of function (assuming active reservoir is R2 and so we would want load cell associated with the inactive reservoir R1 which is A1. So we only need to see if that assumption is wrong here.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-13598-2 22 Sep 2022

Done.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13598-2 22 Sep 2022

Done.

DG-DEN-4322-1 17 Aug 2020

Consider having a property for persistent alarms for whether alarm is clearable. Then, do not do any of the clear alarm logic if not clearable.
User clearing will be handled between UI and HD f/w, so will not be handled in this module.

DG-DEN-4322-1 17 Aug 2020

The conductivity value coming from both FPGA and conductivity sensor is unsigned integer. The conversion to float type is to get the two decimal embedded in the unsigned integer.

DG-DEN-4217-1 14 Aug 2020

Remove extra space between value and override. Should we capitalize override to signal the beginning of the description for that parameter?

DG-DEN-13598-2 22 Sep 2022

Removed test code.

HD-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-13903-1 22 Sep 2022

Missing payload.

UI-DEN-4438-1 25 Aug 2020

done

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 14 Oct 2020

Done

UI-DEN-3149-1 11 Jun 2020

yesyouarerightiamamgoingtodothatanywaybecauseitissohardtomeaswellanditislikethisbecauseitwasthedefaultqtcreatoroptionandididnotchangeitatthattimebutineedatimetochangeitassoonaspossible.

DG-DEN-3922-1 21 Jul 2020

Done

UI-DEN-3149-1 12 Jun 2020

RESOLVED.

UI-DEN-3149-1 23 Jun 2020

msg complete

UI-DEN-3149-1 23 Jun 2020

Remove extra line.

UI-DEN-3253-1 12 Jun 2020

Please do not use QGraphcalEffects our device display resolution and color depth is not supporting it and most of the time it makes application ugly.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3922-1 21 Jul 2020

Done

DIALIN-DEN-3593-1 20 Jul 2020

Done

UI-DEN-3149-1 15 Jun 2020

Thanks Peter for your consult.

This is the link which is used for our C++ coding standard and has been already mentioned as a reference in the doc.
This codding standard and this implementation has been done by having those comments in mind,

There are so many debates on so many c++ features that might be the case people are prefer to use Java or python sometimes.
For example threads are strongly suggested to not to be used until you really need them because they are very hard (or almost impossible) to debug and needs so much work to keep them safe.
But we are using them because we need them.

I put those #define in code to guard the code and I'm willing to keep them at least for quite a while until we are going to refactor them and implement the actual slots when required.
So until then we are not removing them and it remains as it is.

If it's still not clear to you how to use them after I explained, come to me and ask please.

Thanks,

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-3115-1 19 Jun 2020

From a physics perspective, why do we need different PWM ramp up and ramp down rates?

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7044-1 07 Apr 2021

RESOLVED.

UI-DEN-3253-1 06 Jul 2020

Done

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

The counter was supposed to start from 0 but I changed it to 1 and added an = to it too.

UI-DEN-3253-1 07 Jul 2020

RESOLVED.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 12 Jun 2020

We are no using svg.
Please use only png.

DIALIN-DEN-3421-1 10 Dec 2020

Done