•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3922-1 21 Jul 2020

What is our C Coding Standard saying for the maximum width of a code line? Do we need to move things to the next line?

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

DIALIN-DEN-2379-1 07 Jul 2020

RESOLVED

DG-DEN-4217-1 12 Aug 2020

Where is the Doxygen eof /*@}/?

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Sean Nash Could you please respond?

DG-DEN-5980-1 06 Apr 2021

Done.

DG-DEN-4217-1 12 Aug 2020

Good candidate for a two liner...

DIALIN-DEN-3593-1 16 Jul 2020

I'm not sure, it seems like it could be an issue with Fisheye / Crucible? There is only one file on the branch: http://dvm-linux02:7990/projects/VV/repos/dialin/browse/dialin/dg?at=refs%2Fheads%2FDEN-3593-Maintenance

DG-DEN-4217-1 12 Aug 2020

Add empty line after }.

DG-DEN-3421-1 12 Aug 2020

Fixed the logic

DIALIN-DEN-3593-1 20 Jul 2020

Done

DG-DEN-3421-1 12 Aug 2020

Remove extra space on both lines before the "=".

DIALIN-DEN-3593-1 20 Jul 2020

Done

DIALIN-DEN-3593-1 18 Jul 2020

Copyright header missing.

DIALIN-DEN-3964-1 20 Jul 2020

Done

DIALIN-DEN-3964-1 18 Jul 2020

Remove extra line.

DG-DEN-4322-1 15 Aug 2020

Should be 0.0.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-4217-1 12 Aug 2020

Looks like this self test is not fully implemented. Added TODO comment.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Yes, I have seen issues if I don't put it.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

All modules will have doxygen hooks eventually

DG-DEN-3421-1 12 Aug 2020

Will fix this throughout code

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

Planned to catch up in DEN S26.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Is the "\" necessary in C for the Compiler we use?

DG-DEN-4322-1 17 Aug 2020

This is to save the receivers from checking on valid CPi (non-zero) and knowing equation for calculation even through it is a simple division here.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

VV-DEN-1434-1 12 Jun 2020

RESOLVED.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 30 Nov 2020

Dara, it is misspelled.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

Same comment here.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 23 Jun 2020

RESOLVED.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 27 May 2020

Remove commented lines.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.