•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 29 May 2020

I have TODO lines above and at the bottom of the test code area. Please look at lines around #ifdef and #endif

DG-DEN-2379-1 29 May 2020

I have TODO lines above and at the bottom of the test code area. Please look at lines around #ifdef and #endif

HD-DEN-3115-1 29 May 2020

Agreed. Fixed.

DG-DEN-2379-1 29 May 2020

Done

DG-DEN-2379-1 29 May 2020

Done

DG-DEN-2379-1 29 May 2020

I have added the override functions for setting a temperature value and also for changing the publish time. The rest of the functions for setting target temperature and starting the heaters will not be override functions.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 29 May 2020

I added the CAN broadcast function. It will only broadcast the PWM values. The temperature values will be broadcast in TemperatureSensors module.

DG-DEN-2379-1 31 May 2020

The U in 40U, 35U, what are the Us for? Are these units of time? Are these UTC-based time stamps?

DG-DEN-2379-1 31 May 2020

I am not using AE as notepad, I am using my code as notepad. The bulk of the AE documentation is done in the Sub-task but as I am developing, more items need to be added/removed. I always have todos next to them and once in a while I will sweep through them. This was I can ensure that AE is in sync with the firmware.

DG-DEN-2379-1 31 May 2020

Done. This function will be removed after testing.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 31 May 2020

I am sorry, I don't understand the question.

DG-DEN-2379-1 31 May 2020

No, these are unsigned values. For instance, the target temperature is +40 C and it won't -40 C.

DG-DEN-2379-1 31 May 2020

So, U16, U32, for variable types and 40U, 35U for unsigned parameters? Is this following our C Code Standard?

DG-DEN-2379-1 29 May 2020

If test code, add TODO to remember to either put it back in or remove it. Do this everywhere as a rule.

DG-DEN-2379-1 31 May 2020

I only use U in #defines since the type of defined implicitly. For instance you can say #define coeff 2.35 or #define temp 35. So for the integers if they are unsigned, I put the U in the end. But when you define a variable U16 a = 23, then U is not needed because you explicitly define the type of the variable to be a unsigned 16-bit integer. It is for extra safety mostly.

DG-DEN-2379-1 29 May 2020

If test code, add TODO to remember to either put it back in or remove it. Do this everywhere as a rule.

DG-DEN-2379-1 01 Jun 2020

Done

DG-DEN-2379-1 01 Jun 2020

Done

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 29 May 2020

Remove extra line.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 29 May 2020

Remove Extra line.

DG-DEN-2379-1 31 May 2020

I recommend not using Crucible as a notepad. AE activities should be done as part of the "Update Requirements" Sub-Task in Jira.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 31 May 2020

If this function must return "result", why is function void? Is result defined as a static for the entire module?

DG-DEN-2379-1 31 May 2020

FW code base is the wrong place to create an AE to do list.

DG-DEN-2379-1 31 May 2020

What are these Us?

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 01 Jun 2020

Done

DG-DEN-2379-1 01 Jun 2020

SENSOR instead of SESNOR.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 29 May 2020

What is the difference between Readings1 and Readings2? I am not a big fan of iterating function names.

HD-DEN-3115-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 01 Jun 2020

Done

DG-DEN-2379-1 01 Jun 2020

Why did this change? Looks wrong.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 01 Jun 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

I would consider breaking this large function into 3 smaller functions. One for this, one for converting heater temperatures, and one for converting other temperatures. Maybe even more for dealing with error flags, etc...

DG-DEN-4217-1 12 Aug 2020

Missing the Doxygen /*@}/ at eof.

DG-DEN-3922-1 22 Jul 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 12 Jun 2020

Thanks for catching that.
Corrected.

UI-DEN-3149-1 23 Jun 2020

Unable to Resume Ultrafiltration or already running
U for the first word and "Resume Ultrafiltration" as a term for the current action.

UI-DEN-3149-1 12 Jun 2020

put information

DG-DEN-2650-1 04 Jun 2020

This was for testing only and will be removed

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.