Please remove, only files that are needed for the IDEs and builds should be part of the repos to keep them clean. You can use OneNoe, X;/ drive, OneDrive, and your local drive for storing personal TODO lists. The other option is to make TODO comments in the code.
Typically, TODOs are handled by searching the entire codebase for the keyword "TODO" and list shall be reduced to 0 count before any formal release. What is this additional list of TODOs for?
I took a look at the current C++ coding standard, here: X:\Engineering\Denali\06- Software Design\Software Documentation\Coding Standards, but the section on Macros is lacking. Therefore, I consulting an outside coding standard, called C++ Coding Standards 101 Rules, Guidelines, and Best Practices by Herb Sutter and Andrei Alexandrescu. Chapter 16 of this book is entitled “Avoid macros.” There is a quote in this book from Bjarne Stroustrup, creator of the C++ programming language:
“Macros are almost never necessary in C+…” “…The first rule about macros is: Don’t use them unless you have to. Almost every macro demonstrates a flaw in the programming language, in the program or in the programmer.”
Additionally, the authors of the book have these comments on macros:
“An error in a macro can only be reported after the macro is expanded and not when it is defined.” “Always given them SCREAMING_UPPERCASE_AND_UGLY names, and avoid putting them in headers”
If the creator of C+ says don’t use macros unless you have to, I think we should use them sparingly. Each time one of these macros is used in a .h or .cpp file, you have to come back to main.h and deduce the generated code from 2+ layers of macro indirection. This I am sure is very hurtful to the readability of the code. Our coding standard encourages readability, and so I think it is in the spirit of it to limit the use of macros as much as possible.
It needs to be separated at least for now because the icon placement is different now that we are putting the alarm silence icon at the very left of the alarm bar. The small notification bar, which is primarily used inside alerts instead of alarms, does not have alarm specific functions and animation needed for high priority alarms.
This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.
