•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-2379-1 20 May 2020

Should be a @param.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-2652-1 20 May 2020

Addressed.

DG-DEN-2379-1 20 May 2020

Done

DIALIN-DEN-2652-1 20 May 2020

valve state will be an integer so use integer_to_bytearray().

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 20 May 2020

unpack 'f' is for interpreting floats in a byte array. For a U16, use unpack 'H'.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DG-DEN-2379-1 27 May 2020

Match other examples for format.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DIALIN-DEN-2652-1 20 May 2020

See above comment

DG-DEN-2379-1 27 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 27 May 2020

This whole state machine is UF test code (because we don't yet have prescription settings and pre-treatment modes implemented).

DG-DEN-2379-1 27 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 27 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 27 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 27 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Sorry, I developed that for testing but it turned out that I needed it. Added the headers

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

I have added the override function

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

I zero this variable in initTemperatures(). I only check if it is zero so I can get the and start counting. I have created a delay before I go to getADCRead() state. Before I go to the next state, I zero the variable to be used again.

DG-DEN-2379-1 27 May 2020

This is reachable, before I move to this state, I set this variable to 0. Then for the first time it will be 0 and a time is set. Once the time has elapsed, the inlet temperature is checked and the variable is set to 0 for another round of checking.

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 27 May 2020

This module is beyond the scope of this branch. Sean Nash please respond.

DG-DEN-2379-1 27 May 2020

Remove commented out switch statement.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

Add module comment for doxygen.

DIALIN-DEN-2652-1 20 May 2020

Addressed.

DG-DEN-2379-1 20 May 2020

Done

DG-DEN-2379-1 27 May 2020

Done

UI-DEN-3253-1 23 Jun 2020

Removed it, as I think it's not used anymore

DG-DEN-2379-1 27 May 2020

Done

DG-DEN-2379-1 20 May 2020

Output is that primaryHeaterTargetTemperature is set to given temperature.

UI-DEN-3149-1 12 Jun 2020

Refer to my other comment on this type of extra comments.

DG-DEN-2379-1 28 May 2020

RESOLVED in CODE WALKTHROUGH.