•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-1 11 Aug 2020

Isn't this relationship already known?

DG-DEN-3922-1 21 Jul 2020

More specific comment here. This will be picked up by Doxygen. Describe this enumeration.

DG-DEN-3421-1 11 Aug 2020

Should primary heater be turned off here?

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3875-1 12 Aug 2020

Remove extra line.

DG-DEN-3421-1 12 Aug 2020

Isn't the internal FSM used in 2 or more places? Is turning off the heater appropriate in all cases? If not, move outside internal FSM to somewhere specific.

DG-DEN-4217-1 13 Aug 2020

Added to my list of TODOs

DG-DEN-4217-1 11 Aug 2020

Should this not be commented out since there is a ifdef guarding it?

DIALIN-DEN-6078-1 22 Feb 2021

RESOLVED

UI-DEN-3253-1 23 Jun 2020

QtGraphicalEffects is now removed

DIALIN-DEN-2652-1 20 May 2020

Addressed.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-2652-1 20 May 2020

Done.

UI-DEN-3253-1 23 Jun 2020

RESOLVED

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

Done

UI-DEN-3253-1 23 Jun 2020

RESOLVED

DG-DEN-2379-1 20 May 2020

Removed the commented code

DG-DEN-2379-1 20 May 2020

Missing @param.

DIALIN-DEN-2652-1 20 May 2020

It returns False otherwise, not 0

DG-DEN-2379-1 20 May 2020

You have debug code to dump temperature data, but I don't see an actual broadcast on CAN.

UI-DEN-3149-1 19 Jun 2020

Where in the code it shows that we are actually sending a non-zero value to disable this patch? I believe we should completely remove this functionality when the timing is right.

UI-DEN-3253-1 01 Jul 2020

Done

DG-DEN-3922-1 21 Jul 2020

The SYS team says they will need more data and testing to determine the value. This value I use is more like a hardware value.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

UI-DEN-3149-1 12 Jun 2020

RESOLVED.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3149-1 12 Jun 2020

Removed.

DG-DEN-3922-1 21 Jul 2020

Remove extra line.

UI-DEN-3149-1 12 Jun 2020

put information

UI-DEN-3149-1 12 Jun 2020

RESOLVED.

UI-DEN-3149-1 11 Jun 2020

What is the purpose of this comment?

DG-DEN-3922-1 21 Jul 2020

Should this be a conductivity sensor fault?

UI-DEN-3149-1 16 Jun 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 17 Jun 2020

Requested change has been made. Please resolve

DG-DEN-3421-1 12 Aug 2020

Doxygen comment missing.

UI-DEN-3253-1 17 Jun 2020

I spoke with Sean, he said FW doesn't need access to the alarm message text displayed by the UI.

Since they need to be translated, they need to reside here so that the UI can translate them with QObject::tr().

DIALIN-DEN-2379-1 01 Jul 2020

Our python coding standard requires lower_case_with_underscores for variable names and function names

DIALIN-DEN-2379-1 01 Jul 2020

handler_temperature_sensors should be private
e.g.: _handler_temperature_sensors()

DIALIN-DEN-2379-1 01 Jul 2020

Add super()._init_() after inheriting from _AbstractSubSystem

HD-DEN-3115-1 19 Jun 2020

FIQs are non-maskable - cannot protect thread sensitive code from interruption. FIQs were a hopefully temporary way to get the interrupt priority I needed. I reviewed the RM46 datasheet last weekend and found a way to change IRQ priorities and so I no longer need FIQs.

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.