•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4438-1 20 Aug 2020

Priority? (instead of Priory)

UI-DEN-3253-1 23 Jun 2020

I have now removed QtGraphicalEffects and ColorOverlay and modified the svg colors in the svg source

DG-DEN-2379-1 20 May 2020

Done

DG-DEN-4217-1 11 Aug 2020

Replace # with number.

DG-DEN-2379-1 20 May 2020

Removed the commented code

DG-DEN-2650-1 15 May 2020

If max duty cycle is 79.5 %, why are we setting this to 89 %? Same with the below two lines at 50 % against 25 %.

UI-DEN-3253-1 23 Jun 2020

Done

DG-DEN-3421-1 12 Aug 2020

I have not tested many parts of this code yet. I will investigate and change the code if needed.

UI-DEN-3149-1 11 Jun 2020

It's not a comment.
I am just using // in my codes.

DG-DEN-2650-1 20 May 2020

RESOLVED in CODE WALKTHROUGH. Will address in Dara's code walkthrough.

DG-DEN-2379-1 20 May 2020

Remove blank lines between case and code for consistency.

UI-DEN-3253-1 23 Jun 2020

RESOLVED.

UI-DEN-3253-1 15 Jun 2020

Done

DG-DEN-4217-1 12 Aug 2020

Doxygen /*@}/ missing.

UI-DEN-3253-1 15 Jun 2020

Talked with Sean and these are now in the message list

UI-DEN-3149-1 23 Jun 2020

removeFirst (instead of removeFist)?

UI-DEN-3253-1 16 Jun 2020

RESOLVED.

DIALIN-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

UI-DEN-3149-1 17 Jun 2020

Please work on getting it to work again.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3149-1 17 Jun 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 01 Jul 2020

Good catch. I have removed it

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

DG-DEN-3421-1 10 Aug 2020

Add @param to function headers where appropriate.

UI-DEN-3253-1 01 Jul 2020

No problem Behrouz. Your comment is noted.

Since there is no action item in this comment could you resolve it?

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3922-1 21 Jul 2020

Same comment regarding cd1/cd2, here.

DIALIN-DEN-6078-1 20 Feb 2021

Done

DG-DEN-3922-1 21 Jul 2020

Add ///< comments for Doxygen.

UI-DEN-3149-1 17 Jun 2020

Future changes will be tracked in:

http://dvm-linux02:8080/browse/DEN-3743

RESOLVED.

DG-DEN-3922-1 21 Jul 2020

Add ///< comment for Doxygen.

DG-DEN-3922-1 22 Jul 2020

Why was this vectorcast area needed?

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 21 Sep 2022

Added the VectorCAST #define.

UI-DEN-3605-4 30 Sep 2020

I remembered we talked about it.
RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Remove commented line (or add a TODO with clear explanation why this is commented out).

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-13598-2 22 Sep 2022

Explanation has been included in DEN-13834.

DG-DEN-4217-1 17 Aug 2020

Done.

HD-DEN-5053-1 01 Oct 2020

Done.

DG-DEN-3421-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-13460-2 22 Sep 2022

These variables will be deleted.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.