•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13460-2 21 Sep 2022

Done.

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

HD-DEN-3115-1 19 Jun 2020

What setting changed in sys_core? Things were changed at the assembly level.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 29 Oct 2020

Remove extra space.

UI-DEN-3253-1 23 Jun 2020

Done. Do you know QObject::tr is needed in MAlarmStatus.cpp and not here?

UI-DEN-3149-1 19 Jun 2020

Remove extra line.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

I don't have this code in my branch so I didn't comment it out. Comment above should read flow rate out of range?

DIALIN-DEN-2379-1 01 Jul 2020

Use epytext docstring format instead

We're no longer using doxygen in dialin

DIALIN-DEN-2379-1 01 Jul 2020

Needs to be in epytext format so sphinx will pick it up

DIALIN-DEN-13460-1 22 Sep 2022

Sure there is.
But if you keep using the old method we are never done.
Please while you develop/modify the part of the code you can update please do.

Michael Garthwaite,
What is the plan for the following task?
DIAL-171 : Using conversions functions for data instead of index-based

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 11 Aug 2020

Done.

DG-DEN-3421-1 12 Aug 2020

Done

UI-DEN-3875-1 12 Aug 2020

Create utility module (if not already done) with method fromMinToHrs(float min) that converts minutes to hours and call that from here with passed in argument vTreatmentTime.time_Total.

Note: Since this is the JavaScript portion of QML, I leave it up to your best judgment where to define this method, local (only used in this *.qml file) vs. global (used across *.qml files).

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13598-2 22 Sep 2022

Uncommented and removed comment at end of line.

DG-DEN-3421-1 12 Aug 2020

If it starts at 0, >= is appropriate. If it starts at 1, > is appropriate.

DG-DEN-3421-1 11 Aug 2020

Should we fault here?

UI-DEN-3875-1 20 Aug 2020

done

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 11 Aug 2020

Suggest renaming the structure to make it common for both DG and HD or distinguish it from HD.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-13598-2 22 Sep 2022

Done.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-13598-2 22 Sep 2022

Done.

UI-DEN-3875-1 21 Aug 2020

Ok, RESOLVED.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4438-1 25 Aug 2020

RESOLVED.

DIALIN-DEN-3875-1 12 Aug 2020

Remove extra line.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-2652-1 20 May 2020

Addressed.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

Missing @param

DG-DEN-2379-1 20 May 2020

Add blank lines between cases for consistency.

UI-DEN-3149-1 11 Jun 2020

It was, I just added them to repo to keep track of them.

DG-DEN-4217-1 12 Aug 2020

Add extra line between } and function.

UI-DEN-3253-1 15 Jun 2020

Done.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-6078-1 20 Feb 2021

Done

DG-DEN-4217-1 17 Aug 2020

Argument not used in function so I removed.

DG-DEN-3922-1 21 Jul 2020

Agreed! that should have a description of the constant value.