•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-2087-1 24 Apr 2020

Hey, yes this can be resolved. When I first looked over the change, I misread it and thought you were doing a static_cast<QVariant::Type>(vData) instead of static_cast<QVariant::Type>(QMetaType::Float), which gave me pause. Since that's not the case, this change looks good to me

DG-DEN-2652-1 05 May 2020

Agreed and done.

DG-DEN-2652-1 05 May 2020

Good call, I added them and commented them as spare.

DG-DEN-2652-1 05 May 2020

Agreed, if distinction between override or note does not need to be made, then it becomes a simple bitwise operation.

DG-DEN-2652-1 05 May 2020

Agreed and changed.

DG-DEN-2652-1 05 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2652-1 05 May 2020

Deleted.

DG-DEN-2652-1 04 May 2020

Some logic in Valves.c (e.g. the array to U16 function) will require two unused spare enums (where VR1 and VR2 were) be inserted before VPD.

DG-DEN-2652-1 05 May 2020

They should be static, agreed and done.

DG-DEN-2652-1 05 May 2020

Agreed and changed to U08.

DG-DEN-2652-1 05 May 2020

Why are you using int instead of defined integer types?

DG-DEN-2652-1 05 May 2020

RESOLVED in CODE WALKTHROUGH

DG-DEN-2652-1 04 May 2020

Fault?

DG-DEN-2650-1 30 Apr 2020

Measured weight from load cells?

UI-DEN-3024-1 07 May 2020

RESOLVED.

UI-DEN-3024-1 06 May 2020

Where are the descriptive headers for all these functions in this file?

UI-DEN-3024-1 07 May 2020

RESOLVED.

UI-DEN-3024-1 07 May 2020

RESOLVED.

UI-DEN-3024-1 06 May 2020

Remove personal opinion (entire line)

UI-DEN-3024-1 07 May 2020

RESOLVED.

HD-DEN-3115-1 11 May 2020

Unsure. It shouldn't happen as I've not configured any other edges. But if it did, I'm not sure I want to alarm on that - probably no harm in ignoring it. I would like to know it's happening though, so I'm torn.
Thoughts?

HD-DEN-3115-1 11 May 2020

These are structure names. I'm working my way through removing the use of this macro everywhere due to Doxygen issue. Fixed these.

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 11 May 2020

Why start variable name with cap?

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 12 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 13 May 2020

Fixed.

UI-DEN-3149-1 11 Jun 2020

canBusFaultCountData?

UI-DEN-3605-4 05 Oct 2020

RESOLVED

UI-DEN-3149-1 15 Jun 2020

Thanks Peter for catching that.
Removed.

DIALIN-DEN-3922-1 21 Jul 2020

Same comment here on cd1/cd2, I would add them during their Story round.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 15 Jun 2020

During development I must have run into an issue with it being white instead of transparent. It looks like it doesn't make a difference anymore, so I have changed it back to white.

DIALIN-DEN-2652-1 20 May 2020

I think vst will be a single element array. Should be vst[0] I think.
Also, these & operation will yield zero or non-zero bit masks - I think we want boolean (energized/de-energized).

DG-DEN-2379-1 20 May 2020

status is what is returned - not an output. Output is that heater state is reset, primary heater PWM is set, and we go to control to target state if target is non-zero.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

UI-DEN-3149-1 23 Jun 2020

regarding

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed?

UI-DEN-3149-1 23 Jun 2020

msg compelete?

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

HD-DEN-3115-1 19 Jun 2020

Why were the #pragmas removed?

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

UI-DEN-4598-1 29 Oct 2020

Remove extra space.