Seems like this should only be incremented if there is a mismatch between commanded valve states and the valve states read back from the FPGA. And of course reset to zero when they match.
This script has only been moved or renamed, as I am not the original author. In this section, it appears to just be emitting a dummy payload to the DG sync broadcast channel id every second. I don't see how it could interfere with other messages being sent on the CAN bus since it is just adding a little traffic to the bus once every second. The type of other nodes on the bus shouldn't matter.
Yes, This is the Qt way. Signal is a function but Qt by #define and Qt Meta Data classes will handle it in its own way. By calling a signal in QML we are emitting it so the other interested connected class can have a slot to be connected to that signal and implement the behavior.
From a quality and regulatory, what we see in the C++ code must match Diality's C++ Coding Standard. What is why we have that standard in place. Please create a Task for yourself in DEN S18 with highest priority (No. 1) to update the C++ coding standard. Please include Peter's and my time for reviewing the changes, including release of the document through Propel. Thanks!
