Sorry don't understand. If it means extra empty line, all the copyright sections in the files are just before #pragma once with no extra empty line since the first comment block will be folded in one line by QtCreator and it's nice to have #pragma once as much as possible at the top of the file.
1 - It makes the usage of the code, standard like Q_OBJECT and no other way of definition should be used. 2 - It makes the code consistent. 3 - Automatically handles the part of the code which is a copy/paste for just connecting signal/slots. Ans soon ...
No, I think we need to separate them, potentially putting them in a different repository altogether in the future
To avoid deleting people's work, I didn't delete test scripts in this commit. In future commits, I will reach out to people and let them know before they are deleted or moved
SA doc led me to believe they were. I had same initial thought but I could not think of any other DG mode where we would be doing these things. We may be doing some things in other modes that are similar to some of these states, but they are different and I figure those other modes will have their own states even if they are similar to some of these. Fill appears to be the only mode where we are producing dialysate.
In general I don't use set/get if not required and use the function overloading for that purpose which make is like a property that has a single name every where regardless of set or get.
