Comment Search

These make it look like the valve states broadcast message has a 4-byte boolean for each valve, but I see the f/w is only sending one U16 with a bit for each valve.

There is no inputs to this function. targetTemp is a @param.

Add blank line between declarations and function code for consistency.

I know I started this, but I've been removing the redundant function name after "brief" in function headers.

What is the advantage of using macros to define the signals and slots?

This is the extra line after each break.

done

This is what looks best at this time. Flow sensors tend to be pretty accurate if you average over a long time, but very choppy in the short or even medium term. However, if I extend the filter time to 10 s, then the control interval has to be at least 10 s as well. I've discussed with Blaine and Nick to verify this is ok. I think we don't want the blood and dialysate inlet pumps to be very reactive anyway - the treatment lasts 1-8 hours, so we can start with an estimated PWM that will be close and then take a minute to gradually improve on that estimate with our slower control.

remove extra line

remove // process ...

exist

This is temporary and will be removed. I am only reading flow for testing in this module.

What is causing this error? Don't we slow down the UF rate as we see it approaching the upper bound?

Empty?

Interesting that the signal gets defined as signal clicked above but here it gets used as .clicked() as a function call

Will need some bit masking here to extract each valve from the U16.

Remove commented lines.

Why are we adding "" in some function names and in some other cases with just stick the names one after the other without ""?

RESOLVED in CODE WALKTHROUGH.

This code has been modified since.

Done

RESOLVED.

Fixed.

talked with Peter and it's OK.
RESOLVED.

RESOLVED in CODE WALKTHROUGH.