•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

DG-DEN-4217-1 12 Aug 2020

Argument no longer needed?

DIALIN-DEN-2379-1 01 Jul 2020

I think other commits of mine and others are still included in this review that aren't related. Can you point me to the files that you changed?

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3922-1 21 Jul 2020

I think we may want to be a little more forgiving on this. Maybe allow for n errors within some window of time before triggering a fault. I added some functions to support this kind of thing in Utilities module.
Also - should this be a conductivity sensor fault? Need to somehow differentiate from the other fault above so when we see it in a log file we know which occurred.

UI-DEN-3253-1 01 Jul 2020

Done

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Agreed. I will change the location of this function once I started working on this story.

DG-DEN-4322-1 19 Aug 2020

Leaving in place. Grouping of like fields. RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-4217-1 12 Aug 2020

To MessagePayloads.h. I think I'll eventually redistribute these back to the appropriate individual module headers and remove MessagePayloads.h - still working out what makes most sense.

UI-DEN-3875-1 20 Aug 2020

The mL to L is only used in ultrafiltration and only for volume and only for display on screen.
it wasn't worth including utility class here which costs more code and build time only for a division/multiplication.
comment will suffice.

DG-DEN-4217-1 12 Aug 2020

Done

UI-DEN-3253-1 06 Jul 2020

RESOLVED

UI-DEN-3253-1 22 Jun 2020

The parameter alarmID comming from GUI is not required.
This class itself has told GUI what is the alarm by the alarm top id.
Let's talk about it.

DIALIN-DEN-2379-1 01 Jul 2020

Needs to be in epytext format so sphinx will pick it up

DIALIN-DEN-2379-1 01 Jul 2020

Should inhereit from _AbstractSubSystem

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 11 Aug 2020

Align doxygen comment

HD-DEN-13460-2 22 Sep 2022

Done.

DG-DEN-13598-2 22 Sep 2022

Removed.

DG-DEN-4322-1 21 Aug 2020

The new module PersistentAlarm in fwcommon handle this.

HD-DEN-13460-2 22 Sep 2022

The buffer has been increased in the DEN-13903.

DG-DEN-4322-1 21 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 21 Aug 2020

The new module PersistentAlarm in fwcommon handle this.

DG-DEN-4322-1 20 Aug 2020

Why removed?

HD-DEN-13460-2 22 Sep 2022

Done.

HD-DEN-13460-2 22 Sep 2022

Done.

UI-DEN-4438-1 24 Aug 2020

This is the namespace brace and the namespaces braces are not indenting the code. so are at the same column as class brace in this case.

UI-DEN-3149-1 11 Jun 2020

RESOLVED.

UI-DEN-3253-1 15 Jun 2020

Done.

DG-DEN-3421-1 10 Aug 2020

Remove extra space.

DIALIN-DEN-2652-1 20 May 2020

Fixed.

DG-DEN-2379-1 20 May 2020

Input is primaryHeaterTargetTemperature and mainPrimaryHeaterDutyCycle.

UI-DEN-3149-1 17 Jun 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

DG-DEN-3922-1 21 Jul 2020

1. I would call them consistently, cdi, cdo, inlet outlet is too confusing because there is also pressure and temperature;2
2. I would also focus only on cdi cdo and remove cd1/cd2, which have their own Stories.

DG-DEN-4217-1 12 Aug 2020

Add extra line between } and function.

DG-DEN-3421-1 11 Aug 2020

Isn't RO pump already set? If not, what about drain pump?

HD-DEN-3115-1 19 Jun 2020

I re-sized the various stacks.

UI-DEN-3253-1 26 Jun 2020

Yes, I agree. For now, I've updated it so the flag will only disable the HD communication timeout error, instead of all the alarms. This will reduce the scope of the flag and also prevent it from affecting the other squishqt tests before we move things to Dialin.

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

DG-DEN-2650-1 19 Jun 2020

Yes, there are 4 DIP switches that go to GPIO input pins on the RM46 that we can use for engineering/test purposes.

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Updated as suggested.

DG-DEN-4217-1 17 Aug 2020

Planned to be taken care of in DEN S26.

DG-DEN-5855-1 10 Dec 2020

Done