•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3253-1 23 Jun 2020

I have now removed QtGraphicalEffects and ColorOverlay and modified the svg colors in the svg source

UI-DEN-3253-1 23 Jun 2020

perfect.
RESOLVED

UI-DEN-3605-4 30 Sep 2020

RESOLVED.

UI-DEN-3253-1 23 Jun 2020

RESOLVED

HD-DEN-3115-1 19 Jun 2020

HALCoGen removed these when I changed from FIQ to IRQ.

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed?

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

HD-DEN-3115-1 19 Jun 2020

Why were the #pragmas removed?

HD-DEN-3115-1 19 Jun 2020

Why were the #pragmas removed?

DG-DEN-2650-1 19 Jun 2020

Do we have dip switches on the DG Board?

DG-DEN-3922-1 21 Jul 2020

Remove extra line.

DG-DEN-3922-1 21 Jul 2020

I would add that conductivity sensor data is updated with latest readings.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

UI-DEN-3253-1 29 Jun 2020

RESOLVED.

DG-DEN-3421-1 10 Aug 2020

I think I still need this build flag condition to prevent changing of PWM.

UI-DEN-3253-1 01 Jul 2020

Done

UI-DEN-4598-1 29 Oct 2020

Remove extra line.

DIALIN-DEN-2379-1 01 Jul 2020

Ok, please review heaters.py and temperature_sensors.py

DG-DEN-3421-1 12 Aug 2020

Align Doxygen comments

UI-DEN-3253-1 06 Jul 2020

RESOLVED

DG-DEN-4217-1 17 Aug 2020

Done.

UI-DEN-3253-1 06 Jul 2020

RESOLVED

UI-DEN-3253-1 29 Jun 2020

Remove extra line.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-13460-2 21 Sep 2022

Done.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Agreed. Will work on this once I started working on the story

HD-DEN-13460-2 22 Sep 2022

Done.

DG-DEN-3421-1 12 Aug 2020

I prefer not to put ".", but let's make a decision in code walkthrough

UI-DEN-3875-1 20 Aug 2020

done

DG-DEN-4217-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

Some modules that were implemented early like this one have not yet been converted to new Doxygen format. Eventually, we will get all of these older modules caught up, but it takes time so need to create a task in coming sprints to allot some time for it.

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

DG-DEN-4217-1 20 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 20 Aug 2020

It's a test build #. They may do several lab revisions before test results looks good, then roll minor revision.

UI-DEN-3875-1 20 Aug 2020

Sure, but it's a debug code and percent at left makes it not moving much and is readable.

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 12 Aug 2020

Indent line one character to the left to align with upper line for increased legibility.

UI-DEN-3875-1 12 Aug 2020

Create utility class with fromMLtoL method (local or global)

DG-DEN-4322-1 21 Aug 2020

The git rebase operation has affected the review. This PersistentAlarm module has been moved to fwcommon and being deleted in dgfirmware.

DG-DEN-4322-1 21 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4438-1 23 Aug 2020

done

DIALIN-DEN-4322-1 25 Aug 2020

RESOLVED.

DIALIN-DEN-4438-1 20 Aug 2020

Remove extra line.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.