•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-1 10 Aug 2020

Fill out inputs/Outputs on all function headers.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 20 Aug 2020

What is lab rev number and how it is different from minor rev number?

UI-DEN-3875-1 20 Aug 2020

done

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 12 Aug 2020

Align arguments under each other to increase legibility.

UI-DEN-3875-1 12 Aug 2020

LOGGINF?

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-4438-1 23 Aug 2020

done

DIALIN-DEN-4322-1 20 Aug 2020

PEP-8 does not like alignment. Remove extra spaces between arguments and = signs.

DIALIN-DEN-4438-1 25 Aug 2020

RESOLVED.

DG-DEN-4217-1 11 Aug 2020

status is the same as calRecordIsValid. Suggest removing the if statement and assign calRecordIsValid to status.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 12 Jun 2020

Please remove KeepAlive from the list.
We haven't decided to use keepAlive as the check for the communication connection yet.

UI-DEN-3253-1 15 Jun 2020

Done

UI-DEN-3149-1 11 Jun 2020

thisfilenameisquitelongandhardtoreaditwouldbebetterifitwascamelcasewhichIthinkyouarealreadygoingtodowitheveryfile,right?

DIALIN-DEN-2652-1 20 May 2020

I think this needs to be addressed by Sean.

DG-DEN-3421-1 12 Aug 2020

This is not the end of the line, there is another line after this that defines the data publish interval. Also, I wanted to make sure the doxygen comments are aligned.

DG-DEN-3922-1 21 Jul 2020

Why TBD?

UI-DEN-3149-1 16 Jun 2020

RESOLVED

UI-DEN-3149-1 16 Jun 2020

RESOLVED

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Updated as suggested.

UI-DEN-3149-1 23 Jun 2020

If each word starts with capital letter make consistent, other first letter of first word can be capital and all the rest lower cap.

DG-DEN-2379-1 20 May 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

This function will be filled up later. Sean Nash please respond

DG-DEN-3421-1 11 Aug 2020

Make these two lines a one-liner.

DG-DEN-2650-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-2652-1 20 May 2020

RESOLVED

DIALIN-DEN-2652-1 20 May 2020

Please use snake_case: PEP8

Function names should be lowercase, with words separated by underscores as necessary to improve readability.

Variable names follow the same convention as function names.

HD-DEN-11980-1 16 Feb 2022

Fixed. Thanks!

UI-DEN-3149-1 14 Jun 2020

Thanks for catching again.
The spellchecker has been stopped working and I can't make it run again.
Corrected.

DG-DEN-3421-1 12 Aug 2020

Done

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 01 Jul 2020

Done

DG-DEN-4217-1 17 Aug 2020

Be careful merging to make sure this part gets obsoleted.

HD-DEN-3115-1 19 Jun 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 01 Jul 2020

As per our email chain on 6/29, I believe this can be resolved

DIALIN-DEN-6078-1 20 Feb 2021

Done

UI-DEN-3253-1 01 Jul 2020

Makes sense. I've finished the action item above so this is ready to be resolved.

DG-DEN-4217-1 17 Aug 2020

Please remove when doing the merge.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3253-1 14 Jun 2020

MouseArea doesn't need to be parent of any object.
Please move objects out of MouseArea block and move it at the end.

DIALIN-DEN-2379-1 01 Jul 2020

Just need to subclass _AbstractSubSystem, use epytext formatting in all functions, make handler_heaters_sync private (e.g. _handler_heaters_sync), and decorate _handler_headers_sync with the _publish decorator, with a list of all class variables that will be published to observers.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 11 Aug 2020

Replace with function getTargetROPumpFlowRate().

DG-DEN-4322-1 15 Aug 2020

Not all alarms will be cleared in this way. Most alarms that occur during a treatment will be cleared by user action (either acknowledging the alarm or resuming/ending treatment or starting a rinseback.