•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-4211-1 09 Sep 2020

RESOLVED.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-12224-16 23 May 2022

Done.

DG-DEN-3421-1 12 Aug 2020

Done

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 09 Sep 2020

Done.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 17 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 11 Aug 2020

Should this not be commented out since there is a ifdef guarding it?

DG-DEN-3421-1 11 Aug 2020

Should this be an else instead of else if?

UI-DEN-3875-1 14 Aug 2020

With QVERIFY commented out, this isn't testing anything

HD-DEN-4308-3 22 Sep 2020

Blank line is in wrong place.

DG-DEN-4322-1 15 Aug 2020

data parameter is F32 so this else branch seems pointless.

DG-DEN-4322-1 17 Aug 2020

Done.

DG-DEN-4322-1 17 Aug 2020

Fixed.

DG-DEN-4322-1 19 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 17 Aug 2020

Why is this module both in fwcommon and firmware at the same time?

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

HD-DEN-4308-3 22 Sep 2020

Done

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

HD-DEN-4308-3 22 Sep 2020

Done

UI-DEN-4438-1 20 Aug 2020

1. Why is indentation of } off?
2. Also no extra line before }

UI-DEN-3875-1 14 Aug 2020

The percent sign should go after the number, not before it

DIALIN-DEN-6078-1 22 Feb 2021

RESOLVED

UI-DEN-3253-1 23 Jun 2020

Done

DIALIN-DEN-2652-1 20 May 2020

Sure, this is a play space, the V&V ones, however, will be much more controlled. But, I would still recommend using the name of module or epic to avoid including personal names.

DIALIN-DEN-2652-1 21 May 2020

RESOLVED.

DG-DEN-2379-1 20 May 2020

Done

DIALIN-DEN-2652-1 20 May 2020

Fixed.

DIALIN-DEN-2652-1 20 May 2020

RESOLVED

DIALIN-DEN-2652-1 20 May 2020

Don't you need the first element in each tuple?

DG-DEN-2650-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-3115-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 19 May 2020

1. inletTemperatrue?
2. Variable declared but never used?

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 19 May 2020

1. inletTemperatrue?
2. Variable declared but never used?

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-2379-1 20 May 2020

RESOLVED in CODE WALKTHROUGH.