I understand and agree, that's extra work. But that wasn't even part of the Alarm design. This is the settings feature which has not been started yet. That's exactly why we have this interview to let you (or any developer) know the changes before the Unit test/Integration Test/Code Coverage is done and also to know that against which code those test/coverage needs to be done.
I don't think you want to use absolute value here. We need to know positive vs. negative. And we probably should swap order (should be out - in). e.g. if target delta pressure is zero, a negative delta (out - in) would tell us that the RO pump is pulling water faster than the drain pump is pushing (creating a vacuum between them) and we would want the drain pump to speed up. And if delta is positive, that means the drain pump is pushing water faster than the RO pump (creating a pressure build up between them) and we would want the drain pump to slow down.
The mL to L is only used in ultrafiltration and only for volume and only for display on screen. it wasn't worth including utility class here which costs more code and build time only for a division/multiplication. comment will suffice.
This was part of SystemCommMessages.c which has not been updated to new Doxygen format. I think these structures will be moved eventually to their respective module header files and this header file will go away.
I would think this alarm would be triggered generally by driver because current mode said we shouldn't see syringe yet. Can we just set stopPump to TRUE here and nothing else?
