•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-1 10 Aug 2020

There is still a target pressure that gets set after target flow is achieved. We may still want to be able to override it.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-13598-2 22 Sep 2022

Removed.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-5855-1 10 Dec 2020

Done

UI-DEN-4438-1 24 Aug 2020

This is the namespace brace and the namespaces braces are not indenting the code. so are at the same column as class brace in this case.

DG-DEN-3421-1 10 Aug 2020

Should we still have this? See comment in header file.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-3421-1 12 Aug 2020

Remove extra line and don't forget what Doxygen needs as last line in the file.

UI-DEN-3875-1 20 Aug 2020

Change sentence to (so it becomes non-personal): It is preferred to keep it as is so that the initialization is independent of data.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DG-DEN-3421-1 13 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 10 Aug 2020

I don't think you want to use absolute value here. We need to know positive vs. negative. And we probably should swap order (should be out - in). e.g. if target delta pressure is zero, a negative delta (out - in) would tell us that the RO pump is pulling water faster than the drain pump is pushing (creating a vacuum between them) and we would want the drain pump to speed up. And if delta is positive, that means the drain pump is pushing water faster than the RO pump (creating a pressure build up between them) and we would want the drain pump to slow down.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

DIALIN-DEN-11250-1 16 Feb 2022

Added the heprin bolus target rate value override command

DG-DEN-3421-1 12 Aug 2020

I changed the comment to mention a set period of time.

UI-DEN-4438-1 20 Aug 2020

Replace FIXME with TODO, we only use TODO.

DG-DEN-3421-1 12 Aug 2020

Agreed. Will work on this once I started working on the story

UI-DEN-3875-1 20 Aug 2020

The mL to L is only used in ultrafiltration and only for volume and only for display on screen.
it wasn't worth including utility class here which costs more code and build time only for a division/multiplication.
comment will suffice.

DIALIN-DEN-3421-1 10 Dec 2020

RESOLVED.

Crucible was hiding it from me

DG-DEN-3421-1 11 Aug 2020

Replace with function getTargetROPumpFlowRate().

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

DG-DEN-4217-1 12 Aug 2020

This was part of SystemCommMessages.c which has not been updated to new Doxygen format. I think these structures will be moved eventually to their respective module header files and this header file will go away.

HD-DEN-4308-3 29 Aug 2020

This is the retry. In this condition, the number of retries have exceeded and it will alarm.

UI-DEN-3875-1 21 Aug 2020

Ok, RESOLVED

HD-DEN-13598-2 22 Sep 2022

common and fwcommon repos are covered in the 13598 DG code review so not needed here.

DG-DEN-13460-2 22 Sep 2022

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3421-1 11 Dec 2020

RESOLVED

HD-DEN-4308-3 01 Sep 2020

Done

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14001-1 17 Oct 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14170-1 04 Nov 2022

I would think this alarm would be triggered generally by driver because current mode said we shouldn't see syringe yet.
Can we just set stopPump to TRUE here and nothing else?

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

File name must use camelCase.

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

UI-DEN-3605-4 25 Aug 2020

For all these conditions, either one-liner, or left align arguments if cascaded.

UI-DEN-4438-1 20 Aug 2020

Empty?

UI-DEN-3253-1 11 Jun 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Add extra line between } and function.

UI-DEN-3253-1 15 Jun 2020

RESOLVED.

DG-DEN-4217-1 12 Aug 2020

Where were these moved to?

DG-DEN-4217-1 12 Aug 2020

No space between function name and "(" in both functions newly added.

HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

DG-DEN-2650-1 19 Jun 2020

There are many more valves on the DG Device, why setting only these ones?