•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-3115-1 19 Jun 2020

This is the TI copyright that we got these API files originally. Yes, they are different from the other TI files that are generated by HALCoGen but they are still TI files and not ours. When I was working on the copyright script, I realized the script did not realize they are not our files and added our copyright. I enhanced the algorithm that checks whether a file belongs to Diality or not, so this issue will not happen. At the same time, I removed the Diality copyright. I am not sure why there is a "?" in their copyright that does not affect the script's parsing capabilities.

HD-DEN-3115-1 19 Jun 2020

This does not look like TI's typical copyright. And, why was the Diality copyright removed? Last, what are the "?" characters in the TI copyright?

DG-DEN-2650-1 19 Jun 2020

There are many more valves on the DG Device, why setting only these ones?

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

The mL to L is only used in ultrafiltration and only for volume and only for display on screen.
it wasn't worth including utility class here which costs more code and build time only for a division/multiplication.
comment will suffice.

UI-DEN-3253-1 01 Jul 2020

This happened as part of the merge. I think Behrouz is already updating it in his branch. To avoid future merge conflicts, I think it'd be best to ensure the styling issues are fixed only on his branch instead of here too.

UI-DEN-3875-1 12 Aug 2020

Add empty line.

UI-DEN-3253-1 06 Jul 2020

RESOLVED

UI-DEN-3875-1 12 Aug 2020

Always have one empty line at eof.

UI-DEN-3605-4 15 Oct 2020

RESOLVED

DG-DEN-3421-1 12 Aug 2020

I think it's required for macros. I don't believe it's required in normal code like this.

UI-DEN-3253-1 06 Jul 2020

Just to clarify the conversation :
Touch is another set of events in Qt for gestures and single or double touch are still considered click/press/release.
So better to have clicked for single touch.

RESOLVED

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Agreed. Please let me test the code.

DG-DEN-3421-1 11 Aug 2020

Remove commented line.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

HD-DEN-15306-3 02 Jun 2023

Done.

UI-DEN-3875-1 20 Aug 2020

RESOLVED.

UI-DEN-3875-1 12 Aug 2020

1) I would make these hard requirements (0.600, 0.500, etc. constants defined part of a critical data file and called here. This way, we have them all in one place.
2) Shouldn't the minimum be 100 mL (0.100 L)?

UI-DEN-3875-1 12 Aug 2020

Remove extra line.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

DG-DEN-13598-2 22 Sep 2022

Removed.

DG-DEN-4217-1 11 Aug 2020

Done.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

DG-DEN-3421-1 12 Aug 2020

Done

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Agreed. Will fix this once I started working on the story

DG-DEN-4322-1 21 Aug 2020

The new module PersistentAlarm in fwcommon handle this.

HD-DEN-14000-1 13 Oct 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4217-1 12 Aug 2020

This module not yet converted to new Doxygen format.

HD-DEN-13834-1 13 Oct 2022

Still below operation modes exec.

DG-DEN-3421-1 11 Aug 2020

Call to init here is not necessary. Op Modes will call this when transitioning to this mode.

DG-DEN-3421-1 10 Aug 2020

Keep this.

DG-DEN-4217-1 12 Aug 2020

The buffer lock was added long ago to try to help thread protect the buffers. Since IRQs prioritized and FIQs changed to IRQs, this is no longer needed.

HD-DEN-13834-1 17 Oct 2022

RESOLVED IN CODE WALKTHROUGH

DG-DEN-4217-1 12 Aug 2020

Done

DG-DEN-3421-1 10 Aug 2020

F32?

DG-DEN-3421-1 10 Aug 2020

Use drainPumpDACSet here as it is literally being set in next line of code.

DG-DEN-3421-1 10 Aug 2020

Rename TPi to TDi.

DG-DEN-3421-1 10 Aug 2020

Suggest define number 86400 as seconds per day.

DG-DEN-3421-1 10 Aug 2020

Remove extra blank lines.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-3605-4 25 Aug 2020

Remove extra line.

UI-DEN-4438-1 25 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

RESOLVED.

DIALIN-DEN-3875-1 12 Aug 2020

Remove extra line.

UI-DEN-4438-1 25 Aug 2020

done