F/W would be 87 here if we numbered the last "NUM_OF_ALARM_IDS" like Dialin did. And then Dialin has a new valve alarm ID that Dara added so that branch is a little bit ahead of the f/w branch. The alarm IDs are kept in a common repo for all 3 stacks and is shared by all so it can get updated by somebody else.
I think this compound condition is not right. Self test should have to be complete (not or'd with homing request). Homing request can be or'd with door closed.
This is the user adjustments of parameters in pre-treatment which some of them will also be available in-treatment for re-adjustment. So please mention the Adjust.
This is the test code. Not the API, not the production code. And not even being used in documentation. I don't think we need to put comments for these functions as long as the name is self-descriptive within context. As I never asked you to comment on your test functions.
These tests are very thorough and actually test the code on a level not possible with SquishQt. SquishQt is more of a black-box approach and for mission critical sections of the code it cannot cover everything as thoroughly. This test helped me root out bugs as I was writing it. I think it has helped in the development.
How is framFlags related to this function? The return type is FrameCount and as it says it is the count of frames that had an error as the function comment says.
